Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/e57 #21

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Feature/e57 #21

merged 3 commits into from
Sep 22, 2024

Conversation

dancergraham
Copy link
Contributor

Add e57 file support with colors
image

@dancergraham
Copy link
Contributor Author

closes #20

Copy link
Contributor

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Thanks for the contribution. I feel like we would need to use some patterns as the list of possible try/catches is getting too long.

@dancergraham do you need me to spin a new release so you can pip install lidar-visualizer from any machine?

@dancergraham
Copy link
Contributor Author

Yes it would be much neater as a match / case, if matching logic can be defined (e.g. by file extension). A factory pattern would be an obvious choice for building the readers. It would also be good to document the supported file types on the GitHub readme - I had to dig into the source code to see what was supported.

No rush for a release on my side - I can build from source as needed, though I'll get that warm fuzzy feeling when I see it go out to PyPI

@nachovizzo nachovizzo merged commit 622591e into PRBonn:main Sep 22, 2024
6 checks passed
@dancergraham dancergraham deleted the feature/e57 branch September 22, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants