Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(new) GZ Feature tracker #23602

Open
12 of 30 tasks
Jaeyoung-Lim opened this issue Aug 22, 2024 · 11 comments · Fixed by #23943 · May be fixed by #23783
Open
12 of 30 tasks

(new) GZ Feature tracker #23602

Jaeyoung-Lim opened this issue Aug 22, 2024 · 11 comments · Fixed by #23943 · May be fixed by #23783
Labels
feature-request Sim: gazebo Gazebo simulator (gz)

Comments

@Jaeyoung-Lim
Copy link
Member

Jaeyoung-Lim commented Aug 22, 2024

Describe problem solved by the proposed feature

This is a feature tracker to achieve feature parity with gazebo classic.

Feed free to modify the issue to append the list or mark it as completed. If there is an issue/PR, please reference it.

Describe your preferred solution

The list of features that are missing in the new GZ is as follows:

Models

Worlds

  • Ocean
  • Baylands

PX4 related Features

Sensors

Actuators

  • Wind influence for motor thrust
  • Wind influence for lift and drag plugin

Simulation Features

Describe possible alternatives

NA

Additional context

@dakejahl
Copy link
Contributor

Add optical flow to the sensors list. I can help with creating the plugin architecture, I just need to find some time to do it.

@mrpollo
Copy link
Contributor

mrpollo commented Aug 22, 2024

Maybe add switching the MAVSD SITL tests to the new GZ as well. I can take care of it once we have faster than real-time.

@Jaeyoung-Lim Jaeyoung-Lim added the Sim: gazebo Gazebo simulator (gz) label Aug 23, 2024
@dirksavage88
Copy link
Contributor

  1. Collision prevention/obstacle distance already exists in PX4 gz with the x500 lidar model:

  2. Catapult is just a Wrench publisher in GZ and a model would purely be for visual purposes. Easy to implement outside of PX4:
    gz topic -t /world/default/wrench -m gz.msgs.EntityWrench -p 'entity:{name:"x_500",type:MODEL},wrench:{force: {x:32000,y:0,z:8500,}}' -n 100

  3. Airspeed is in GZ garden, but not yet in a PX4 plugin: https://github.com/gazebosim/gz-sensors/blob/gz-sensors7/src/AirSpeedSensor.cc

Multivehicle simulation as in multiple PX4 capable vehicles or just one PX4 vehicle and another controlled externally?

@Jaeyoung-Lim
Copy link
Member Author

@dirksavage88

Collision prevention/obstacle distance already exists in PX4 gz with the x500 lidar model:

I know, but does the test work?

Catapult is just a Wrench publisher in GZ and a model would purely be for visual purposes. Easy to implement outside of PX4:
gz topic -t /world/default/wrench -m gz.msgs.EntityWrench -p 'entity:{name:"x_500",type:MODEL},wrench:{force: {x:32000,y:0,z:8500,}}' -n 100

We need to write a plugin that does it automatically on arm to make testing more convenient. It doesn't make sense to type that everytime you test it.

Airspeed is in GZ garden, but not yet in a PX4 plugin: https://github.com/gazebosim/gz-sensors/blob/gz-sensors7/src/AirSpeedSensor.cc

That is just the sensor implementation. We need to incorporate it into gz bridge and handle the airframe configs for it.

@dirksavage88
Copy link
Contributor

@dirksavage88

Collision prevention/obstacle distance already exists in PX4 gz with the x500 lidar model:

I know, but does the test work?

Catapult is just a Wrench publisher in GZ and a model would purely be for visual purposes. Easy to implement outside of PX4:
gz topic -t /world/default/wrench -m gz.msgs.EntityWrench -p 'entity:{name:"x_500",type:MODEL},wrench:{force: {x:32000,y:0,z:8500,}}' -n 100

We need to write a plugin that does it automatically on arm to make testing more convenient. It doesn't make sense to type that everytime you test it.

Airspeed is in GZ garden, but not yet in a PX4 plugin: https://github.com/gazebosim/gz-sensors/blob/gz-sensors7/src/AirSpeedSensor.cc

That is just the sensor implementation. We need to incorporate it into gz bridge and handle the airframe configs for it.

By test, this is in reference to a unit test of some sort? I am not sure how tests were carried out in gazebo classic.

@Myzhe
Copy link

Myzhe commented Oct 1, 2024

Maybe add distance sensors (rangefinders) to the sensor list.

@github-actions github-actions bot removed the stale label Oct 2, 2024
@dirksavage88 dirksavage88 linked a pull request Oct 7, 2024 that will close this issue
@dirksavage88
Copy link
Contributor

@Jaeyoung-Lim Please see the following PR for faster than real time support

@hamishwillee
Copy link
Contributor

This is very nice!! Note, we need to make sure these things are documented. Feature parity also means "works out of the box", not "we added a distance sensor to the model, but actually it can only be used from ROS if you know what you are doing, maybe ...".

@Claudio-Chies
Copy link
Contributor

There seems to be a bug regarding the interaction of the Advanced Lift Drag plugin, and the windy world. where the advanced plane gets blown away before takeoff. make px4_sitl gz_advanced_plane_windy
might be added to this list?
#24064

@Jaeyoung-Lim
Copy link
Member Author

@Claudio-Chies Lets keep bugs away from this thread and focus on missing features. Once the features are ported, bugs should be treated as is

@dakejahl
Copy link
Contributor

I started on adding plugin support for gz, looking for input
#24153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Sim: gazebo Gazebo simulator (gz)
Projects
Status: ✅ Done
8 participants