rover flight modes: Specify speed axis #3530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No flaws found |
| @@ -18,7 +18,7 @@ Manual modes require stick inputs from the user to drive the vehicle. | |||
|
|
|||
| The sticks provide the same "high level" control effects over direction and rate of movement in all manual modes: | |||
|
|
|||
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling forward speed) | |||
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling longitudinal speed) | |||
There was a problem hiding this comment.
I guess longitudinal is OK. I preferred the original. I.e. this means "controlling forward backward speed".
Suggested change
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling longitudinal speed) | |
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling speed) |
Why? Well when someone says longitudinal I'm thinking, now what does that mean? It's accurate, but not as immediately obvious as forwards/backwards.
So I'd prefer it done like this and as in https://github.com/PX4/PX4-user_guide/pull/3530/files#r1894469734
BUT you have broad ownership of this area, so if you strongly prefer longitudinal then please merge this as-is. Otherwise change.
| @@ -31,7 +31,7 @@ The manual modes provide progressively increasing levels of autopilot support fo | |||
|
|
|||
| ::: details Overview mode mapping to control effect | |||
|
|
|||
| | Mode | Forward speed | Steering angle/lateral acceleration | Required measurements | | |||
| | Mode | Longitudinal speed | Steering angle/lateral acceleration | Required measurements | | |||
There was a problem hiding this comment.
You could do this as (everywhere)
Suggested change
| | Mode | Longitudinal speed | Steering angle/lateral acceleration | Required measurements | | |
| | Mode | Forward/backwards speed | Steering angle/lateral acceleration | Required measurements | |
| @@ -18,9 +18,9 @@ Manual modes require stick inputs from the user to drive the vehicle. | |||
|
|
|||
| The sticks provide the same "high level" control effects over direction and rate of movement in all manual modes: | |||
|
|
|||
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling forward speed) | |||
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling longitudinal speed) | |||
There was a problem hiding this comment.
Suggested change
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling longitudinal speed) | |
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling speed) |
| - `Left stick left/right`: Yaw the rover to the left/right (controlling yaw rate). | ||
| - `Right stick left/right`: Drive the rover left/right (controlling lateral speed) | ||
| - `Right stick left/right`: Drive the rover left/right (controlling lateral speed). |
There was a problem hiding this comment.
Suggested change
| - `Right stick left/right`: Drive the rover left/right (controlling lateral speed). | |
| - `Right stick left/right`: Drive the rover left/right (controlling speed). |
| @@ -33,7 +33,7 @@ The manual modes provide progressively increasing levels of autopilot support fo | |||
|
|
|||
| ::: details Overview mode mapping to control effect | |||
|
|
|||
| | Mode | Forward/Lateral speed | Yaw rate | Required measurements | | |||
| | Mode | Longitudinal/Lateral speed | Yaw rate | Required measurements | | |||
There was a problem hiding this comment.
This case perhaps makes sense to keep as longitudinal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewording to differentiate between longitudinal (forward/backwards) and lateral (left/right) motion.