[WIP] Add surface support #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… _concat_surf_imgs utility function
…masker method for clarity
…existing test readability
…mat code; remove unused _concat_surf_imgs function
…n and improve code readability
|
Thanks for opening, @pbarbarant ! Let us know when ready for review ; I think this will hugely improve things 🚀 |
|
The main difficulty lies in nilearn/nilearn#4756. After that, the new backend should be able to work seamlessly with surface data. |
…es and improve assertions
|
Will be operational as soon as nilearn/nilearn#4974 closes. |
|
CI will pass as soon as nilearn's new release rolls out. |
bthirion
approved these changes
Dec 19, 2024
| n_pieces = 2 | ||
| n_vertices_total = img.shape[0] | ||
| parcel_masker = ParcellationMasker(n_pieces=n_pieces) | ||
| fitted_parcel_masker = parcel_masker.fit(img) |
There was a problem hiding this comment.
Suggested change
| fitted_parcel_masker = parcel_masker.fit(img) | |
| parcel_masker = parcel_masker.fit(img) |
|
You can do an early with my branch: I'd rather make sure that the release does not have another bug that this one was hiding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73.