Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.6.0 #40

Merged
merged 8 commits into from
Nov 19, 2023
Merged

Release 2.6.0 #40

merged 8 commits into from
Nov 19, 2023

Conversation

jenia81
Copy link
Collaborator

@jenia81 jenia81 commented Nov 5, 2023

  • Add support for an external signing tool
    • The feature enables to use of an external signing tool for signing the manifest.
    • Add a new CLI option --signing-tool to the manifest-dev-tool init command.
    • The --key CLI option of the manifest-dev-tool init command can receive an identifier private key
      or a private key file name that will be used to sign the manifest with the external signing tool provided.
    • Add a new configuration option signing-tool that is used by the manifest-tool create command.
    • The --key CLI option of the manifest-tool create or manifest-tool create-v1 command can receive
      an identifier private key or a private key file name that will be used to sign the manifest with
      the external signing tool provided.
    • Add unit tests for the new feature.
  • Update requests to 2.31.0.
  • Update cryptography to 41.0.4.
  • Add support for Python 3.11 (super inits, imports with try, tox additions etc.).
  • Update dev-requirements:
    • Update pytest to the latest 7.4.2.
    • Update pylint to 2.17.7 (3.0.2 does not support older versions of Python).
  • Remove the --force CLI option that was deprecated already.

manifesttool/mtool/actions/create.py Fixed Show fixed Hide fixed
manifesttool/dev_tool/actions/init.py Dismissed Show resolved Hide resolved
manifesttool/dev_tool/actions/init.py Dismissed Show resolved Hide resolved
manifesttool/dev_tool/actions/init.py Dismissed Show resolved Hide resolved
manifesttool/mtool/actions/create.py Dismissed Show resolved Hide resolved
@jenia81
Copy link
Collaborator Author

jenia81 commented Nov 9, 2023

@JanneKiiskila Please check the code scanning errors
The logs are only for the certificate path, not its content
And I wouldn't drop them since it helps with debugging

@JanneKiiskila
Copy link
Contributor

@jenia81 - cleared false positives with comments. Resolved comments.

Copy link
Contributor

@JanneKiiskila JanneKiiskila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the cronjobs from this repo.

@jenia81
Copy link
Collaborator Author

jenia81 commented Nov 16, 2023

@JanneKiiskila dropped the cron job from the GitHub action
It's a bit tricky to add the condition to the workflow
I can add it before the steps like this:
if: github.repository == 'PelionIoT/manifest-tool' && github.event.schedule != '0 0 */3 * *'
But then the job will start its execution so the machine will be allocated, just the execution time will be shorter.
The only way to make sure that it won't run at all is to create a difference between the workflow files in internal and public repos

@JanneKiiskila
Copy link
Contributor

The only way to make sure that it won't run at all is to create a difference between the workflow files in internal and public repos

I think we will be fine with that.

@jenia81 jenia81 merged commit 2c44d6e into master Nov 19, 2023
13 of 14 checks passed
@jenia81 jenia81 deleted the release-2.6.0 branch November 19, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants