Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the create-linux-wheels #51

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix the create-linux-wheels #51

merged 1 commit into from
Sep 30, 2024

Conversation

jenia81
Copy link
Collaborator

@jenia81 jenia81 commented Sep 30, 2024 •
edited
Loading

  • Fix the create-linux-wheels
    • Revert the permissions of the build_manylinux_wheels_entry_point.sh back to 755 instead of 644
    • Bump the actions/upload-artifacts to v4
    • If no files were uploaded - throw an error
    • Install rust
    • Add safe dir
  • Update pip
  • Store pysh results to a log-file (archive should catch them).
  • Update actions/python to v5.
  • Update manylinux variants.
  • Update requeststo 2.23.3, as 2.23.0 was yanked!

Code commit instructions

  • Keep PR code size small. Reviewing should not take more than 15 minutes.
  • Write good description of the changes proposed in the pull request.
  • Add reviewers

@jenia81 jenia81 mentioned this pull request Sep 30, 2024
Closed
5 tasks
@jenia81 jenia81 changed the title Fix the create-linux-wheels: Fix the create-linux-wheels Sep 30, 2024
@jenia81 jenia81 force-pushed the release-2.6.2-rc2 branch 4 times, most recently from 817cb16 to ac43094 Compare September 30, 2024 11:27
@JanneKiiskila
Copy link
Contributor

Pysh nags about something still.
Should we actually also install the rust? Or update pip?
I have some changes in my branch.

@jenia81 jenia81 force-pushed the release-2.6.2-rc2 branch 4 times, most recently from 4ffabd8 to 273e702 Compare September 30, 2024 14:08
@jenia81
* Fix the create-linux-wheels
43aee12 
  * Revert the permissions of the `build_manylinux_wheels_entry_point.sh` back to 755 instead of 644
  * Bump the actions/upload-artifacts to v4
  * If no files were uploaded - throw an error
  * Install rust
  * Add safe dir
* Update pip
* Store pysh results to a log-file (archive should catch them).
* Update actions/python to v5.
* Update manylinux variants.
  * See https://github.com/pypa/manylinux
  * We should not use EOL manylinux variants.
  * Add musl_linux_1_2.
* Update requeststo 2.23.3, as 2.23.0 was yanked!
@jenia81 jenia81 merged commit f2f702d into master Sep 30, 2024
14 checks passed
@jenia81 jenia81 deleted the release-2.6.2-rc2 branch September 30, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanneKiiskila JanneKiiskila JanneKiiskila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenia81 @JanneKiiskila