Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdev logging fix #110

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Subdev logging fix #110

merged 6 commits into from
Sep 27, 2024

Conversation

JanneKiiskila
Copy link
Collaborator

Mbed Edge pull request

Description

Improve subdevice FOTA logging in firmware downloads.

Test instructions

  1. Configure the FW download path to a folder, which does not exist (or to which we have no write rights). Verify logs.

  2. Use a file download URL, which does not contain a file. Verify logs.

Check list

API change(s)

  • Not applicable.
  • API is backwards compatible.
  • API documentation is updated.

Example applications updated

  • Not applicable.

Changelog

  • CHANGELOG.md updated.

State explicitly to which filename we are trying to write.
Rather than ., because with LmP releases the filesystem is immutable
in most places and thus you can't download anything there.
The existing error log is not detailed enough, we should print out
the offending URL so that it can be checked.
Need to update the CHANGELOG as well.
Copy link

@petedyerarm petedyerarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanneKiiskila JanneKiiskila merged commit f493a7a into master Sep 27, 2024
3 checks passed
@JanneKiiskila JanneKiiskila deleted the subdev-logging-fix branch September 27, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants