Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to expose minio port number on 9001 #93

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

saikumar-vs
Copy link

@saikumar-vs saikumar-vs commented Nov 18, 2024

Fix minio port number, as we start pmm-sever on 9000 already in pipelines

out tests on pipeline results : https://github.com/percona/pmm-qa/actions/runs/11888886744/job/33124333617

Fix minio port number, as we start pmm-sever on 9000 already in pipelines
Copy link
Collaborator

@sandraromanchenko sandraromanchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does break integration tests - see results of test runs. Also it's not a proper way to change default port for minio server, please check https://min.io/docs/minio/linux/reference/minio-server/minio-server.html#minio.server.-address

In addition, 9000 is used further in config and tests, please adjust them as well.

Thank you Sandra for the quick review. Adjusting only the exposed port resolved the issue and should not disturb the existing Minio setup.
@saikumar-vs
Copy link
Author

This change does break integration tests - see results of test runs. Also it's not a proper way to change default port for minio server, please check https://min.io/docs/minio/linux/reference/minio-server/minio-server.html#minio.server.-address

In addition, 9000 is used further in config and tests, please adjust them as well.

Thank you for the quick review Sandra. Adjusting only the exposed port resolved the issue and should not disturb the existing Minio setup.

@saikumar-vs saikumar-vs reopened this Nov 18, 2024
@saikumar-vs saikumar-vs changed the title Update docker-compose-sharded.yaml Update to expose minio port number on 9001 Nov 18, 2024
@saikumar-vs saikumar-vs merged commit f0c601d into v3 Nov 19, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants