Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authn): improve jwks refresh retry mechanism #1319

Merged

Conversation

charlie-retzler
Copy link
Contributor

  • Address race conditions with fetching JWKS with backoff retry logic
  • Reduce concurrent calls to Refresh when multiple requests in retry logic concurrently
  • Improve tests to validate number of retries and latency of authentication calls
  • Prevent a successful KID that has not needed a refresh from resetting backoff retries

@charlie-retzler charlie-retzler changed the title Improve jwks refresh retry mechanism feat(authn): improve jwks refresh retry mechanism Jun 25, 2024
@charlie-retzler
Copy link
Contributor Author

@ioneyed these are the changes we discussed related to #1299

@tolgaOzen
Copy link
Member

Hi @charlie-retzler, thank you for your contribution!

@tolgaOzen tolgaOzen merged commit 2f1c8e5 into Permify:master Jun 28, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants