-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove max_items constraint from repeated validation rule #1853
Conversation
WalkthroughThis pull request focuses on updating the version number from "v1.2.3" to "v1.2.4" across multiple files in the Permify project. The changes are primarily version increments in documentation and configuration files, including API reference documents, OpenAPI specifications, and internal version tracking. The modifications do not introduce any functional changes to the API or service implementation. Changes
Possibly related PRs
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pkg/pb/base/v1/service.pb.validate.go (1)
5700-5703
: LGTM! Validation changes align with PR objectives.The changes correctly maintain the minimum validation of 1 tuple while removing the maximum limit constraint, as intended by the PR.
Consider the performance implications of removing the upper limit on tuples. While this provides more flexibility, you may want to consider:
- Adding rate limiting or pagination if not already present
- Monitoring system resource usage with larger tuple sets
- Documenting any practical limits based on system capabilities
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
pkg/pb/base/v1/openapi.pb.go
is excluded by!**/*.pb.go
pkg/pb/base/v1/service.pb.go
is excluded by!**/*.pb.go
📒 Files selected for processing (6)
docs/api-reference/apidocs.swagger.json
(1 hunks)docs/api-reference/openapiv2/apidocs.swagger.json
(1 hunks)internal/info.go
(1 hunks)pkg/pb/base/v1/service.pb.validate.go
(1 hunks)proto/base/v1/openapi.proto
(1 hunks)proto/base/v1/service.proto
(0 hunks)
💤 Files with no reviewable changes (1)
- proto/base/v1/service.proto
✅ Files skipped from review due to trivial changes (4)
- internal/info.go
- proto/base/v1/openapi.proto
- docs/api-reference/openapiv2/apidocs.swagger.json
- docs/api-reference/apidocs.swagger.json
Summary by CodeRabbit
New Features
Tuples
andAttributes
in requests.Bug Fixes
Tuples
fields without imposing upper limits.