add extern to function declarations #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code compiled with gcc10 will not link properly due to multiple definition of the same function. ld: /home/abuild/rpmbuild/BUILD/xen-4.8.20191211T160002.8db85532cb/non-dbg/stubdom/vtpm/vtpm.a(vtpm_cmd.o):(.bss+0x28): multiple definition of `tpm_malloc'; /home/abuild/rpmbuild/BUILD/xen-4.8.20191211T160002.8db85532cb/non-dbg/stubdom/vtpm/vtpm.a(vtpm.o):(.bss+0x728): first defined here Signed-off-by: Olaf Hering <[email protected]> Reviewed-by: Jason Andryuk <[email protected]> Acked-by: Samuel Thibault <[email protected]> Reviewed-by: Ian Jackson <[email protected]> Release-acked-by: Paul Durrant <[email protected]> Move over from xen repo. Signed-off-by: Jason Andryuk <[email protected]>
|
I was briefly confused by this, as functions are extern by default in C, but these are function pointers, so the extern makes a difference and resolves the issue. |
|
Thanks, I fall into this problem with gcc 11.4 and find that gcc 10 change its default behavior about global variable (defaulted to -fcommon for gcc < 10 and -fno-common for gcc >= 10). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code compiled with gcc10 will not link properly due to multiple
definition of the same function.
ld: /home/abuild/rpmbuild/BUILD/xen-4.8.20191211T160002.8db85532cb/non-dbg/stubdom/vtpm/vtpm.a(vtpm_cmd.o):(.bss+0x28): multiple definition of `tpm_malloc'; /home/abuild/rpmbuild/BUILD/xen-4.8.20191211T160002.8db85532cb/non-dbg/stubdom/vtpm/vtpm.a(vtpm.o):(.bss+0x728): first defined here
Signed-off-by: Olaf Hering [email protected]
Reviewed-by: Jason Andryuk [email protected]
Acked-by: Samuel Thibault [email protected]
Reviewed-by: Ian Jackson [email protected]
Release-acked-by: Paul Durrant [email protected]
Move over from xen repo.
Signed-off-by: Jason Andryuk [email protected]