Skip to content

Commit

Permalink
[Chore] Clean up unused exported types
Browse files Browse the repository at this point in the history
  • Loading branch information
Pewtro committed Apr 12, 2024
1 parent c7705e8 commit e912aa1
Show file tree
Hide file tree
Showing 101 changed files with 132 additions and 251 deletions.
4 changes: 0 additions & 4 deletions src/analysis/classic/deathknight/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
4 changes: 0 additions & 4 deletions src/analysis/classic/druid/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { AnyEvent } from 'parser/core/Events';
import { Info } from 'parser/core/metric';
import castCount from 'parser/shared/metrics/castCount';

export interface LowRankSpells {
interface LowRankSpells {
[primarySpellId: number]: number[];
}

Expand Down
4 changes: 0 additions & 4 deletions src/analysis/classic/hunter/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ export default lowRankSpells;
export const whitelist = {
[SPELLS.EXPLOSIVE_SHOT.id]: [60052],
};

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { AnyEvent } from 'parser/core/Events';
import { Info } from 'parser/core/metric';
import castCount from 'parser/shared/metrics/castCount';

export interface LowRankSpells {
interface LowRankSpells {
[primarySpellId: number]: number[];
}

Expand Down
4 changes: 0 additions & 4 deletions src/analysis/classic/mage/arcane/CONFIG.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ import type Config from 'parser/Config';

import CHANGELOG from './CHANGELOG';

export enum Build {
DEFAULT = 'default',
}

const config: Config = {
// The people that have contributed to this spec recently. People don't have to sign up to be long-time maintainers to be included in this list. If someone built a large part of the spec or contributed something recently to that spec, they can be added to the contributors list. If someone goes MIA, they may be removed after major changes or during a new expansion.
contributors: [jazminite],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,7 @@ import SPELLS from 'common/SPELLS/classic/mage';
const NEW_ARCANE_MISSILES_TIMEOUT = 5000;
const ARCANE_MISSILES_BOLT_COUNT = 5;

export interface ArcaneMissilesLog {
arcaneMissilesCastEvents: CastEvent[];
arcaneMissilesDamageEvents: DamageEvent[];
}

export interface ArcaneMissilesBeginChannelEvent extends BeginChannelEvent {
interface ArcaneMissilesBeginChannelEvent extends BeginChannelEvent {
arcaneMissilesCastEvents: CastEvent[];
arcaneMissilesDamageEvents: DamageEvent[];
}
Expand Down
4 changes: 0 additions & 4 deletions src/analysis/classic/mage/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
4 changes: 0 additions & 4 deletions src/analysis/classic/paladin/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
4 changes: 0 additions & 4 deletions src/analysis/classic/priest/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
4 changes: 0 additions & 4 deletions src/analysis/classic/rogue/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import SPELLS from 'common/SPELLS/classic/shaman';
import { TotemElements } from 'analysis/classic/shaman/shared/totems/totemConstants';
import { TotemTracker } from 'analysis/classic/shaman/shared';

export interface ChecklistProps extends BaseChecklistProps {
interface ChecklistProps extends BaseChecklistProps {
totemTracker: TotemTracker;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import SPELLS from 'common/SPELLS/classic';
import { TotemElements } from 'analysis/classic/shaman/shared/totems/totemConstants';
import { TotemTracker } from 'analysis/classic/shaman/shared';

export interface ChecklistProps extends BaseChecklistProps {
interface ChecklistProps extends BaseChecklistProps {
totemTracker: TotemTracker;
}

Expand Down
4 changes: 2 additions & 2 deletions src/analysis/classic/shaman/shared/TotemTracker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ import {
TOTEMS_BY_ELEMENT,
} from './totems/totemConstants';

export interface TotemEventTracker {
interface TotemEventTracker {
[TotemElements.Fire]: TotemEvent[];
[TotemElements.Water]: TotemEvent[];
[TotemElements.Earth]: TotemEvent[];
[TotemElements.Air]: TotemEvent[];
}

export interface TotemEvent {
interface TotemEvent {
totemSpellId: number;
totemName: string; // This is just to make debugging easier
summonedAt: number;
Expand Down
4 changes: 0 additions & 4 deletions src/analysis/classic/shaman/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
4 changes: 0 additions & 4 deletions src/analysis/classic/warlock/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ export default lowRankSpells;
export const whitelist = {
[SPELLS.LIFE_TAP.id]: [1454],
};

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
4 changes: 0 additions & 4 deletions src/analysis/classic/warrior/shared/lowRankSpells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,3 @@ const lowRankSpells = Object.entries(SPELLS).reduce((result, [str, obj]) => {
}, {});

export default lowRankSpells;

export interface LowRankSpells {
[primarySpellId: number]: number[];
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import SUGGESTION_IMPORTANCE from 'parser/core/ISSUE_IMPORTANCE';
import { BoolThreshold, ThresholdStyle, When } from 'parser/core/ParseResults';
import * as React from 'react';

export interface RuneForgeCheckItem {
interface RuneForgeCheckItem {
forge: Enchant;
importance: SUGGESTION_IMPORTANCE;
suggestion: React.ReactNode;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Analyzer from 'parser/core/Analyzer';
import { Uptime } from 'parser/ui/UptimeBar';
import { DamageEvent } from 'parser/core/Events';

export type TrackedHit = {
type TrackedHit = {
mitigated: boolean;
event: DamageEvent;
};
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import SPELLS from 'common/SPELLS/demonhunter';
import { TALENTS_DEMON_HUNTER } from 'common/TALENTS/demonhunter';
import Analyzer, { Options, SELECTED_PLAYER } from 'parser/core/Analyzer';
import Events, { CastEvent, ChangeBuffStackEvent, Event, EventType } from 'parser/core/Events';
import Events, { CastEvent, ChangeBuffStackEvent, EventType } from 'parser/core/Events';
import EventEmitter from 'parser/core/modules/EventEmitter';
import BoringSpellValueText from 'parser/ui/BoringSpellValueText';
import Statistic from 'parser/ui/Statistic';
Expand All @@ -11,11 +11,6 @@ import SoulFragmentsTracker, { MAX_SOUL_FRAGMENTS } from '../features/SoulFragme

const REMOVE_STACK_BUFFER = 100;

export interface ConsumeSoulFragmentsEvent extends Event<EventType.ConsumeSoulFragments> {
spellId: number;
numberofSoulFragmentsConsumed: number;
}

class SoulFragmentsConsume extends Analyzer {
static dependencies = {
soulFragmentsTracker: SoulFragmentsTracker,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { shouldIgnore } from 'parser/shared/modules/hit-tracking/utilities';
import { TALENTS_DEMON_HUNTER } from 'common/TALENTS/demonhunter';
import HitBasedAnalyzer from 'analysis/retail/demonhunter/vengeance/guide/HitBasedAnalyzer';

export type TrackedHit = {
type TrackedHit = {
mitigated: boolean;
event: DamageEvent;
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { shouldIgnore } from 'parser/shared/modules/hit-tracking/utilities';
import { TALENTS_DEMON_HUNTER } from 'common/TALENTS/demonhunter';
import HitBasedAnalyzer from 'analysis/retail/demonhunter/vengeance/guide/HitBasedAnalyzer';

export type TrackedHit = {
type TrackedHit = {
mitigated: boolean;
event: DamageEvent;
};
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/retail/druid/feral/modules/core/Snapshots.ts
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ export type SnapshotSpec = {
};

/** Data object recording a period of time that a DoT was active, and which snapshots it benfitted from */
export type DotUptime = {
type DotUptime = {
/** Timestamp when this debuff was applied or refreshed */
start: number;
/** Timestamp when we expect the debuff to expire */
Expand Down
6 changes: 3 additions & 3 deletions src/analysis/retail/druid/restoration/modules/core/Mastery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ class Mastery extends Analyzer {
/**
* A mapping from spell guid to the MasteryAttribution for that spell
*/
export type MasteryAttributionsBySpell = { [key: number]: MasterySpellAttribution };
type MasteryAttributionsBySpell = { [key: number]: MasterySpellAttribution };

/**
* A HoT's mastery attribution.
Expand All @@ -346,7 +346,7 @@ export class MasterySpellAttribution {
/**
* A mapping from buff guid to the attribution amount for that buff
*/
export type MasteryAttributionsByBuff = { [key: number]: MasteryBuffAttribution };
type MasteryAttributionsByBuff = { [key: number]: MasteryBuffAttribution };

/**
* A Buff's mastery attribution.
Expand All @@ -364,7 +364,7 @@ export class MasteryBuffAttribution {
/**
* A instance of healing that has been decomposed into parts based on Mastery attribution
*/
export interface DecomposedHeal {
interface DecomposedHeal {
/** The amount of effective healing that would have been done before being boosted by mastery */
noMastery: number;
/** The amount of effective heal added per stack of mastery */
Expand Down
2 changes: 1 addition & 1 deletion src/analysis/retail/druid/shared/spells/ConvokeSpirits.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ export function isConvoking(c: Combatant): boolean {
export default ConvokeSpirits;

/** A tracker for things that happen in a single Convoke cast */
export interface ConvokeCast {
interface ConvokeCast {
timestamp: number;
/** A mapping from spellId to the number of times that spell was cast during the Convoke */
spellIdToCasts: number[];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export type BreathOfEonsWindows = {
end: number;
};

export type BreathWindowPerformance = {
type BreathWindowPerformance = {
temporalWoundsCounter: SpellTracker[];
ebonMightDroppedDuringBreath: boolean;
ebonMightDroppedDuration: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const { BLAZING_SHARDS, OBSIDIAN_SHARDS } = SPELLS;

const { DRAGONRAGE_TALENT } = TALENTS_EVOKER;

export type BlazeShardCounters = {
type BlazeShardCounters = {
castTimeStamp: number;
extraDamageProvided: number;
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type PurifyBreakdown = {
[key: number]: number;
};

export type MaxHPEvent = AnyEvent & { maxHitPoints?: number };
type MaxHPEvent = AnyEvent & { maxHitPoints?: number };

/**
* Fabricate events corresponding to stagger pool updates. Each stagger
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { EventType, GetRelatedEvents, CastEvent } from 'parser/core/Events';
import { Condition, tenseAlt } from 'parser/shared/metrics/apl';
import { Range, formatRange } from 'parser/shared/metrics/apl/conditions';

export interface Options {
interface Options {
targetType: EventType;
targetSpell: Spell;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const TWO_PIECE_SPELLS = [
SPELLS.GUST_OF_MISTS_CHIJI,
];

export interface ChiHarmonySourceMap {
interface ChiHarmonySourceMap {
raw: number;
amount: number;
effective: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import {
import { MANA_TEA_MAX_STACKS, MANA_TEA_REDUCTION } from '../../constants';
import Haste from 'parser/shared/modules/Haste';

export interface ManaTeaTracker {
interface ManaTeaTracker {
timestamp: number;
manaSaved: number;
totalVivifyCleaves: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { ATONEMENT_DAMAGE_SOURCES } from '../../constants';
import AtonementApplicationSource from '../features/AtonementApplicationSource';
import isAtonement from './isAtonement';

export enum SourceProvenance {
enum SourceProvenance {
Atonement = 'Atonement',
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ export function IsPenanceHealEvent(event: HealEvent): event is PenanceHealEvent
return (event as PenanceHealEvent).penanceBoltNumber !== undefined;
}

export interface PenanceHealEvent extends HealEvent {
interface PenanceHealEvent extends HealEvent {
penanceBoltNumber: number;
}
2 changes: 1 addition & 1 deletion src/analysis/retail/rogue/shared/FilteredDamageTracker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { AnyEvent, CastEvent, DamageEvent, HealEvent } from 'parser/core/Events'
import DamageTracker from 'parser/shared/modules/AbilityTracker';
import { ReactNode } from 'react';

export type FilteredDamageObserver = (event: CastEvent) => void;
type FilteredDamageObserver = (event: CastEvent) => void;

class FilteredDamageTracker extends DamageTracker {
castObservers: FilteredDamageObserver[] = [];
Expand Down
4 changes: 0 additions & 4 deletions src/common/SPELLS/Spell.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ export interface Enchant extends Spell {
effectId: number;
}

export interface SpellList<T extends Spell = Spell> {
[key: string | number]: T;
}

export const isSpell = (x: unknown): x is Spell => {
const typedObj = x as Spell;
return (
Expand Down
2 changes: 1 addition & 1 deletion src/common/TALENTS/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ enum EntryType {
Passive = 'passive',
}

export interface TalentDefinitionId {
interface TalentDefinitionId {
id: number;
specId: number;
}
Expand Down
Loading

0 comments on commit e912aa1

Please sign in to comment.