Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split app from framework #37

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

brent-hoover
Copy link
Contributor

Major restructure that breaks out the an example app from the core framework. Lots of moving stuff around and breaking out the actual loading of plugin files between example app and core. Still some issues:

  • Auth plugin is still sort of split between core and plugin. Where should it live? Don't really want to have people copy the auth plugin in, but also would like to make it optional if they want to roll their own auth.
  • Still have to drop actual files into a plugins directory. Is that a bad thing? Should we have the option to use files OR import from a package. Especially since Typescript seems to make it really easy to have virtual packages. 🤷 One big advantage of being able to import directly from an npm package would be where there are community packages available that people want to use and not just copy the files in.

As of this PR being opened the app doesn't fully load when the cart and discount plugins are installed as I get a graphql error. Still working on that which is why it's still a draft but that's a small implementation detail

@brent-hoover brent-hoover requested a review from aldeed July 14, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant