Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 1.0.0 #59

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Prepare release 1.0.0 #59

merged 4 commits into from
Jun 5, 2024

Conversation

dlouseiro
Copy link
Member

No description provided.

@dlouseiro dlouseiro self-assigned this Jun 4, 2024
@dlouseiro dlouseiro requested review from michael-the1, matthieucan and a team June 4, 2024 09:41
@michael-the1
Copy link
Collaborator

Time for version 1.0? 🤔

@dlouseiro
Copy link
Member Author

Time for version 1.0? 🤔

The idea for version 1 was when something like this would be implemented for all tables, but we can always use it for version 2!

@michael-the1
Copy link
Collaborator

For me it's fine either way, but 1.0 to me implies stability and this has been very stable for a long time now.

@dlouseiro
Copy link
Member Author

For me it's fine either way, but 1.0 to me implies stability and this has been very stable for a long time now.

Indeed! Let's go for 1.0.

We're only missing one approval on this one!

@dlouseiro dlouseiro changed the title Prepare release 0.10.0 Prepare release 1.0.0 Jun 4, 2024
@dlouseiro
Copy link
Member Author

For me it's fine either way, but 1.0 to me implies stability and this has been very stable for a long time now.

Indeed! Let's go for 1.0.

We're only missing one approval on this one!

Updated to 1.0 @michael-the1

@dlouseiro dlouseiro requested a review from matthieucan June 5, 2024 09:12
matthieucan
matthieucan approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@matthieucan matthieucan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little question, but approving. Great achievement to release 1.0.0! 🚀

CHANGELOG.md
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [1.0.0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a mention of the change done in #55?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do! WIll also mention this one

michael-the1
michael-the1 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@michael-the1 michael-the1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@dlouseiro dlouseiro merged commit cc6ccc3 into master Jun 5, 2024
6 checks passed
@dlouseiro dlouseiro deleted the dlouseiro/prepare-release-0.10.0 branch June 5, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieucan matthieucan matthieucan approved these changes

@michael-the1 michael-the1 michael-the1 approved these changes

Assignees

@dlouseiro dlouseiro

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlouseiro @michael-the1 @matthieucan