Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed the experiment manager issue #135 it seems that the issue was in the
execute_runs()
function in the experiment_manager.py file.The function is trying to call ponyge.py as an executable string in the subprocess call, but can't find it as it's not in the current working directory.
I added a call in the experiment_manager.py
main()
function to change the directory to the parent dirchdir("..")
that allowed ponyge.py to run and resolved some file path issues for grammars and datasets.I also added the parent directory to the path with pathlib as only the current working directory scripts got added when experiment_manager.py is run.
I also updated some module imports that didn't work with the new directory structure.
I ran the example problems as tests with
experiment_manager.py
and with the standardponyge.py
on a Macbook running Python 3.8.5 with no issues.