Use Pandas instead of Numpy to store datasets. Implement GE_GENERATE #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GENERATE. In PonyGE#145, @cgarcia-UCO had some nice ideas for new auto-generated grammar content. We discussed it a bit more and we had ideas for users writing executable code inside the grammar. I implemented that. And it turned out to require another change, storing our datasets as Pandas DataFrames, because it requires a datatype per column. That has knock-on effects, including in our bnf files. I've implemented all that. I'm not sure if all this would be acceptable to everyone... so, just making a PR for discussion, or at least to hold this code for posterity.
|
Seems fine to me, maybe some sort of release note should be added to the
readme noting from version X.X we have moved to data being stored as pandas
data frames.
Dave
…On Wed, 3 Aug 2022 at 21:23, James McDermott ***@***.***> wrote:
In #145 <#145>, @cgarcia-UCO
<https://github.com/cgarcia-UCO> had some nice ideas for new
auto-generated grammar content. We discussed it a bit more and we had ideas
for users writing executable code inside the grammar. I implemented that.
And it turned out to require another change, storing our datasets as Pandas
DataFrames, because it requires a datatype per column. That has knock-on
effects, including in our bnf files. I've implemented all that. I'm not
sure if all this would be acceptable to everyone... so, just making a PR
for discussion, or at least to hold this code for posterity.
------------------------------
You can view, comment on, or merge this pull request online at:
#161
Commit Summary
- 3936888
<3936888>
Use Pandas instead of Numpy to read and store datasets. Implement
GE_GENERATE.
File Changes
(11 files <https://github.com/PonyGE/PonyGE2/pull/161/files>)
- *M* grammars/supervised_learning/Banknote.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-c6a1262c1e244aca30381833b8ce9f3ca28adf749559753c3329546f2e8be621>
(2)
- *M* grammars/supervised_learning/Dow.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-c12df75ebe2c807f327816460e5b4861c50009b32ab8829344995bab64cc11d6>
(2)
- *M* grammars/supervised_learning/Keijzer6.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-0186342485892cd916196c79aee98b8b0954728cae15c710f7a0f3fed54b6c8a>
(2)
- *M* grammars/supervised_learning/Vladislavleva4.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-cea7fec3ec0aa69fa302cae96573b1176a01e26eea84f5e49d451bb0586dca05>
(2)
- *M* grammars/supervised_learning/boolean.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-7dc0e2d1367f1ffe4846468f70de25bb8fb7272609aff34ee8368b0a5791ffba>
(2)
- *M* grammars/supervised_learning/if_else_classifier.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-d87cfa24d882fcc4ef6fc96a606e55c6c66d707891023830afdf8d081786b8ab>
(2)
- *M* grammars/supervised_learning/supervised_learning.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-fa3eaebd01a135e16276f6ddec379ebc913083016949c8b9547711971a960301>
(2)
- *M* grammars/supervised_learning/supervised_learning_consts.bnf
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-da42368f681db776f152c3c0ee7682ffe800cb86f00da654fa1e3d2eb6e291b3>
(2)
- *M* src/fitness/supervised_learning/supervised_learning.py
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-ed4f67bc86bf5426358e0444dd7bd07eb2b7ba56ccb56e68d950a01b8fe744b3>
(2)
- *M* src/representation/grammar.py
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-42de969b4497d67825ce9296a546893a4aae4827c0b752f067e8159f337713fd>
(150)
- *M* src/utilities/fitness/get_data.py
<https://github.com/PonyGE/PonyGE2/pull/161/files#diff-1b73847acae47253ddfebde9ff3bcd98102849b21c85389202088dc9ef8938d8>
(54)
Patch Links:
- https://github.com/PonyGE/PonyGE2/pull/161.patch
- https://github.com/PonyGE/PonyGE2/pull/161.diff
—
Reply to this email directly, view it on GitHub
<#161>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHTHOUHT4BTHJQWZYRZ2KTVXLIMRANCNFSM55QEJL2Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #145, @cgarcia-UCO had some nice ideas for new auto-generated grammar content. We discussed it a bit more and we had ideas for users writing executable code inside the grammar. I implemented that. And it turned out to require another change, storing our datasets as Pandas DataFrames, because it requires a datatype per column. That has knock-on effects, including in our bnf files. I've implemented all that. I'm not sure if all this would be acceptable to everyone... so, just making a PR for discussion, or at least to hold this code for posterity.