Build fixes for Android (using libudev-zero) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes build issues for libfido2 on Android (Yubico#247), where libudev-zero is used as a replacement for libudev. explicit_bzero is not found in the Android libc, but the symbol is defined and exported by libcrypto, so I added CRYPTO_EXPLICIT_BZERO to make it possible to use the symbol from that library instead with the right declarations/definitions. I have no idea if it works, but it does build for me now.
As for dependency injection, I've got a lot more changes on my branch, but the whole thing needs major refactoring that should probably come in a second pull request. I build all of the dependencies statically for all platforms and inject them explicitly into my builds.