-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WeBWorK 2.19 support (Tacoma 2024 project) #2336
base: master
Are you sure you want to change the base?
Conversation
Thanks for putting this together for us. |
I've checked all of this against existing behavior, and will have some comments in a minute. But, I don't see any reason to not start testing behavior on Runestone now, step (3) of above with @bnmnetp. |
Thanks, @Alex-Jordan for putting all of this together. Some comments:
Not much, given the quantity of code. Good job. I'm going to familiarize myself with the new features now, so may have more to say. But wanted to get this going in the right direction as quickly as possible. |
OK, I see |
And with AIM's 2.19 server, the |
|
Ideally, an Ubuntu package would provide what I need? |
Yes, the |
Thanks, @drgrice1! I needed the following Ubuntu packages to get through the sample chapter.
|
Built representations throug to the end. Some non-fatal errors. About 6 instances, problem numbers 62-68 (or so), and maybe the very last one. Can't tell what I might be missing.
|
Thanks Rob! Some quick responses and I may do more this evening.
What's going on here is the PTX HTML page has a div with id
OK, I will follow up with this.
I neglected to test with the makefile but I'll do that to make sure things are still working. I was testing by running
Are you viewing with
Sounds like an oversight. Will follow up.
I'll add to the documentation as best I can about what packages are needed. Or maybe a generic "you may need to install some perl packages". With Ubuntu packages, using
This indicates a host course doesn't have the access it needs to the |
I think that this was when @rbeezer was testing the local approach based on the output line "sending webwork-62 to socket". The local approach adds the macros directory in the generated directory to the macro path. So the macro should be available. Although, I also don't see that path in the output that @rbeezer showed. |
Looking over the diff, I think this is from |
OK, this one is addressed. I added a commit (rather than force push) but it can be squashed later as it indicates. |
Copy-paste oversight. The second one should have had its title changed to be about using a renderer. |
@drgrice1 Do you have a recommendation about what I should put in the documentation about which perl version (or later) is required for local PG processing? |
I am not exactly sure how old of a Perl version will work for local PG processing. I know that Perl 5.16 or newer is certainly needed. I suspect that versions that old will have problems though. I think that 5.26 is probably the oldest that we should try to support, and so I guess put that in the documentation. Although you would need 5.32 or newer for a version that I can truly guarantee everything will work for. |
This is a large PR, just in time for everyone to be going on vacation :)
I'm doing my best to group the contributions from @drgrice1. @drdrew42, and myself from Tacoma. According to my testing, with these changes:
Once using a 2.19 server, there are new features that I have tested and documented using the minimal webwork example and the sample-chapter.
Possibly, we need a schedule for pulling the trigger on this. Here's a draft.