Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] : webSocketConfig, CorsConfig에서 CORS 설정 수정 #100

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Mar 15, 2024

close #99

📑 작업 상세 내용

  • corsConfig 수정
    • allowedOrigin -> allowedOriginPatterns
    • 중복되는 webmvc cors 설정 삭제
  • websocketConfig 수정
  • allowedOrigin -> allowedOriginPatterns
  • 채팅 상세조회 응답값에 biddingPrice 추가

💫 작업 요약

  • websocketConfig 수정

🔍 중점적으로 리뷰 할 부분

  • CorsConfig

@hyun2371 hyun2371 added feat New feature or request refactor 리팩토링 labels Mar 15, 2024
@hyun2371 hyun2371 requested a review from ParkJuhan94 March 15, 2024 08:01
@hyun2371 hyun2371 self-assigned this Mar 15, 2024
@hyun2371 hyun2371 changed the title [feat] : websocketConfig 수정 [feat] : webSocketConfig, CorsConfig에서 cors 설정 수정 Mar 15, 2024
@hyun2371 hyun2371 changed the title [feat] : webSocketConfig, CorsConfig에서 cors 설정 수정 [feat] : webSocketConfig, CorsConfig에서 CORS 설정 수정 Mar 15, 2024
Copy link

Test Results

116 tests  ±0   116 ✅ ±0   26s ⏱️ -1s
 29 suites ±0     0 💤 ±0 
 29 files   ±0     0 ❌ ±0 

Results for commit 33da75d. ± Comparison against base commit 429128b.

@hyun2371 hyun2371 merged commit 0f4a163 into dev Mar 15, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#99/websocket-edit branch March 15, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request refactor 리팩토링 빠른 리뷰가 필요해요!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] : websocketConfig 수정
2 participants