Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] : 리뷰 등록 API 개선 #104

Merged
merged 16 commits into from
Mar 18, 2024
Merged

[feat] : 리뷰 등록 API 개선 #104

merged 16 commits into from
Mar 18, 2024

Conversation

ParkJuhan94
Copy link
Contributor

close #98

📑 작업 상세 내용

  • ReviewResponse 분리
    • ReviewSimpleResponse : 단순 리뷰 조회용
    • ReviewDetailResponse : 리뷰 작성 후 영수증 발급용
  • 리뷰 등록 후, 거래 영수증을 발급하기 위하여 ReviewDetailResponse 에 필드가 여러개 추가되었습니다.

특히 거래 완료 시간을 응답에 포함하기 위한 로직이 다수 추가되었습니다.

거래 완료 시간을 포함하기 위해 Bidding 엔티티에 tradingCreatedAt 필드를 추가하고,
RegisterBidding() 에서 updateTradingCreatedAt() 해줍니다.

💫 작업 요약

  • ReviewResponse 분리
  • ReviewDetailResponse 에 거래 영수증을 위한 필드 추가
  • Bidding 에 tradingCreatedAt 필드 추가 후 업데이트 로직 추가

🔍 중점적으로 리뷰 할 부분

  • ReviewService
  • BiddingService
  • Bidding
  • ReviewApiControllerTest

@ParkJuhan94 ParkJuhan94 added the feat New feature or request label Mar 15, 2024
@ParkJuhan94 ParkJuhan94 requested a review from hyun2371 March 15, 2024 17:15
@ParkJuhan94 ParkJuhan94 self-assigned this Mar 15, 2024
Copy link

github-actions bot commented Mar 15, 2024

Test Results

122 tests  +122   122 ✅ +122   27s ⏱️ +27s
 31 suites + 31     0 💤 ±  0 
 31 files   + 31     0 ❌ ±  0 

Results for commit 8f9e9b7. ± Comparison against base commit ec2af7e.

♻️ This comment has been updated with latest results.

Copy link
Member

@hyun2371 hyun2371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다. tradeCreatedAt 필드를 추가하는게 맞는지 고민해보면 좋을 것 같아요! bidding 완료 이후에 업데이트 될 일이 없어서 updatedAt을 거래완료 일시로 써도 되지 않을까 생각도 듭니다.

@ParkJuhan94 ParkJuhan94 requested a review from hyun2371 March 17, 2024 19:39
@ParkJuhan94 ParkJuhan94 merged commit 0da8943 into dev Mar 18, 2024
3 checks passed
@ParkJuhan94 ParkJuhan94 deleted the feat/#98/improve branch March 18, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] : 리뷰 등록 API 개선
2 participants