[feat] : 채팅방 메시지 조회 API 개선 및 응답값 추가 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ParkJuhan94
approved these changes
Mar 18, 2024
| ChatRoom chatRoom = getChatRoomById(chatRoomId); | ||
| Slice<ChatMessageResponse> responsePage = chatMessageRepository | ||
| .findByChatRoomOrderByCreatedAt(chatRoom, pageable) | ||
| .findByChatRoom(chatRoom, pageable) |
There was a problem hiding this comment.
결과가 같아서명시해주지 않으면 오래된순으로 정렬이라고 생각했습니다! 이 부분은 저도 헷갈리네요
There was a problem hiding this comment.
디폴트가 OrderByCreatedAt 인가 보군요!
디폴트 정렬이 헷갈리니까 정렬 기준을 명시해주는 것도 좋은 것 같습니다
hyun2371
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분