Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] : 댓글 생성 및 조회 #123

Merged
merged 18 commits into from
Mar 20, 2024
Merged

[feat] : 댓글 생성 및 조회 #123

merged 18 commits into from
Mar 20, 2024

Conversation

hyun2371
Copy link
Member

📑 작업 상세 내용

  • 댓글 생성 API
  • 입찰 상태에만 가능하도록 검증 로직 추가
  • 한 경매에 대한 댓글 모두 조회 API

💫 작업 요약

  • 댓글 생성 API
  • 댓글 조회 API

hyun2371 added 18 commits March 19, 2024 20:53
@hyun2371
[feat] : 댓글 관련 요청/응답값 추가
714c18e
@hyun2371
[feat] : 댓글 관련 에러 코드 추가
508f245
@hyun2371
[feat] : 댓글 엔티티 repository 추가
6c82ec8
@hyun2371
[style] : 댓글 등록 요청 dto 네이밍 수정
851b895
@hyun2371
[feat] : 댓글 dto<->entity Mapper 추가
6f4217d
@hyun2371
[feat] : 댓글 등록 시 경매 상태 검증하는 엔티티 비즈니스 로직 추가
06e594e
@hyun2371
[feat] : 필드 수정 및 팩토리 메서드 추가
7126cef
@hyun2371
[feat] : 댓글 작성 서비스 로직 추가
d142c6b
@hyun2371
[test] : 댓글 작성 서비스 로직 테스트
adc4d98
@hyun2371
[feat] : 댓글 등록 controller 메서드 작성
c34bb9c
@hyun2371
[test] : 댓글 등록 controller 메서드 작성 테스트
d8abfa9
@hyun2371
[feat] : Comment Mapper 수정
ae8da2b
@hyun2371
[feat] : comment repository 조회 로직 수정
8eafbd9
@hyun2371
[feat] : 경매로 댓글 조회 서비스 로직 작성
726ac73
@hyun2371
[fix] : 쿼리 파라미터 부여
38a3b47
@hyun2371
[feat] : 댓글 조회 컨트롤러 메서드 작성
af8feab
@hyun2371
[test] : 댓글 조회 컨트롤러 메서드 테스트
1fcbba1
@hyun2371
[style] : 코드 리포멧팅
5dc7a7e
@hyun2371 hyun2371 added the feat New feature or request label Mar 20, 2024
@hyun2371 hyun2371 requested a review from ParkJuhan94 March 20, 2024 01:55
@hyun2371 hyun2371 self-assigned this Mar 20, 2024
@hyun2371 hyun2371 linked an issue Mar 20, 2024 that may be closed by this pull request
[feat] : 댓글 생성 및 조회 #120
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Test Results

127 tests  +5   127 ✅ +5   28s ⏱️ -2s
 33 suites +2     0 💤 ±0 
 33 files   +2     0 ❌ ±0 

Results for commit 5dc7a7e. ± Comparison against base commit 8549aad.

ParkJuhan94
ParkJuhan94 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@ParkJuhan94 ParkJuhan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@hyun2371 hyun2371 merged commit bdacbe4 into dev Mar 20, 2024
3 checks passed
@hyun2371 hyun2371 deleted the feat/#120/comment-create-get branch March 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkJuhan94 ParkJuhan94 ParkJuhan94 approved these changes

Assignees

@hyun2371 hyun2371

Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] : 댓글 생성 및 조회
2 participants
@hyun2371 @ParkJuhan94