Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] : 수신자 bidder로 고정된 오류 해결 #152

Merged
merged 3 commits into from
Mar 24, 2024
Merged

[fix] : 수신자 bidder로 고정된 오류 해결 #152

merged 3 commits into from
Mar 24, 2024

Conversation

hyun2371
Copy link
Member

@hyun2371 hyun2371 commented Mar 24, 2024 •
edited
Loading

📑 작업 상세 내용

  • 수신자 고정
    • seller와 user 비교 시 객체가 아닌 아이디로 비교하게끔 수정
  • 응답시 경매 endDate를 localdatetime으로 변환해 반환
    • 프론트엔드 요청 사항

💫 작업 요약

  • receiver 구하는 로직 오류 해결
  • endDate 응답값 localDate -> localDateTime

🔍 중점적으로 리뷰 할 부분

  • 급한 수정사항이라 바로 머지하겠습니다!

@hyun2371 hyun2371 added the fix Something isn't working label Mar 24, 2024
@hyun2371 hyun2371 requested a review from ParkJuhan94 March 24, 2024 05:46
@hyun2371 hyun2371 self-assigned this Mar 24, 2024
@hyun2371 hyun2371 linked an issue Mar 24, 2024 that may be closed by this pull request
[fix] : 수신자 bidder로 고정된 오류 해결 #151
Closed
@hyun2371 hyun2371 added the feat New feature or request label Mar 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2024 •
edited
Loading

Test Results

130 tests  ±0   130 ✅ ±0   28s ⏱️ -4s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit 4df5e65. ± Comparison against base commit eb5c966.

♻️ This comment has been updated with latest results.

@hyun2371 hyun2371 merged commit 1aba615 into dev Mar 24, 2024
3 checks passed
@hyun2371 hyun2371 deleted the fix/#151/receiver-fix-error branch March 24, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkJuhan94 ParkJuhan94 Awaiting requested review from ParkJuhan94

Assignees

@hyun2371 hyun2371

Labels
feat New feature or request fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] : 수신자 bidder로 고정된 오류 해결
1 participant
@hyun2371