[feat] : 회원 엔티티와 회원가입 api 구현 절반 / 패키지 구조 변경 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyun2371
approved these changes
Feb 16, 2024
| @Pattern(regexp = "^[0-9a-zA-Z]([-_.]?[0-9a-zA-Z]){0,19}" | ||
| + "@[0-9a-zA-Z]([-_.]?[0-9a-zA-Z]){0,19}+[.][a-zA-Z]{2,3}$", | ||
| message = "이메일 주소 양식을 확인해주세요") | ||
| String email, |
There was a problem hiding this comment.
@Pattern은 entity 내에서 Assert가 안되는건지 궁금합니다!
There was a problem hiding this comment.
아 가능한데 빠트렸네요! 뒤에 PR 에서 첨가할게요~
|
|
||
| public static String getNotEmptyMessage(String object, String variable) { | ||
| return object + "_" + variable + NOT_EMPTY_POSTFIX; | ||
| } |
There was a problem hiding this comment.
기존에 있던 파일 같은데, 패키지 구조 변경하면서 추가됐다고 나오는 걸까요??
There was a problem hiding this comment.
getNotEmpty�PostFix -> getNotEmptyMessage 제 기억이 맞다면 이렇게 변경했습니다!
메서드명이 너무 어색하더라구요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 작업 상세 내용
회원가입 API관련한 서비스 메서드와, 밸리데이션, 엔티티를 보완하여 추가했습니다.레이어 -> 도메인도메인 -> 레이어💫 작업 요약
🔍 중점적으로 리뷰 할 부분