Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] : 경매 검색 필터 수정 #86

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

hyun2371
Copy link
Member

close #85

📑 작업 상세 내용

  • 시작가 대신 최근 입찰가로 필터링
  • minPrice maxPrice 둘 중 하나만 적용도 가능하도록 수정

💫 작업 요약

  • 경매 검색 필터 수정

@hyun2371 hyun2371 added the refactor 리팩토링 label Mar 13, 2024
@hyun2371 hyun2371 requested a review from ParkJuhan94 March 13, 2024 12:20
@hyun2371 hyun2371 self-assigned this Mar 13, 2024
@hyun2371 hyun2371 linked an issue Mar 13, 2024 that may be closed by this pull request
2 tasks
Copy link

Test Results

113 tests  ±0   113 ✅ ±0   25s ⏱️ -1s
 28 suites ±0     0 💤 ±0 
 28 files   ±0     0 ❌ ±0 

Results for commit b1900f0. ± Comparison against base commit ddd015a.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
dev.handsup.auction.repository.auction.AuctionQueryRepositoryImplTest ‑ [경매 시작 금액으로 경매를 필터링할 수 있다.(initPriceBetween)]
dev.handsup.auction.repository.auction.AuctionQueryRepositoryImplTest ‑ [상품 카테고리로 경매를 필터링할 수 있다.(categoryEq)]
dev.handsup.auction.repository.auction.AuctionQueryRepositoryImplTest ‑ [경매 시작 금액에 max값을 설정해 필터링할 수 있다.(maxLoe)]
dev.handsup.auction.repository.auction.AuctionQueryRepositoryImplTest ‑ [경매 시작 금액에 min값을 설정해 필터링할 수 있다.(minGoe)]

Copy link
Contributor

@ParkJuhan94 ParkJuhan94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴니다

@hyun2371 hyun2371 merged commit c017d79 into dev Mar 14, 2024
3 checks passed
@hyun2371 hyun2371 deleted the refactor/#85/edit-search-filter branch March 14, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] : 경매 검색 필터 수정
2 participants