-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] : 마이페이지 프로필 조회 #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨습니다! 개인적으로 기본 정보가 잘 안 와닿아서 상세정보나 프로필 조회로 고려해봐도 좋을 것 같아요!
@@ -78,4 +79,14 @@ public ResponseEntity<PageResponse<UserReviewResponse>> getUserReviews( | |||
return ResponseEntity.ok(response); | |||
} | |||
|
|||
@NoAuth | |||
@GetMapping("/api/users/{userId}/bases") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uri에 bases 대신 info나 detail, mypage를 넣으면 더 직관적일 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 위의 코멘트랑 맞춰서 profiles 로 해보겠습니다!
import java.util.List; | ||
|
||
public record UserBasicInfoResponse( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
userId도 반환해주면 좋을 것 같아요!
close #93
close #95
📑 작업 상세 내용
프로필 이미지, 닉네임, 동, 선호 카테고리의 List<String>, 점수
를 응답으로 반환합니다.User 엔티티에 비즈니스 메서드
를 만들었습니다.음수 OR 200 초과
를 검사하여 다시 갱신합니다.점수 -> 신뢰도
로 변환합니다.💫 작업 요약
🔍 중점적으로 리뷰 할 부분