Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests & Linting fixes #20

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Tests & Linting fixes #20

merged 7 commits into from
Mar 4, 2024

Conversation

Lewdcario
Copy link
Contributor

@Lewdcario Lewdcario commented Mar 4, 2024

  • Fixes the formatting process to use prettier first then eslint due to undesirable opinionated choices from prettier
  • Remove prettier check from lint script as it has undesirable checks without being filtered through eslint
  • Adds build & lint workflow to get over some problems before publishing this package
  • Fixes issue in Jest testing environment where the code would continue to run after the jest environment has been torn down - addressed by loading the events after the Promise.all call. This is a good change because we want to make sure the bot is fully loaded before tackling events that could have knock-on effects. It does delay startup a bit but this is a one-server bot, so there should be minimal problems with this approach
  • Fix some minimal typos in files
  • All other changes are related to running the formatter across the project

Copy link
Member

@bowenjw bowenjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@bowenjw bowenjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Lewdcario Lewdcario merged commit 79a3c50 into main Mar 4, 2024
2 checks passed
@Lewdcario Lewdcario deleted the test/workflow branch March 4, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants