Use PHPCS (and fix PSR2 style)

ProtonMail · Oct 17, 2023 · a411c19 · a411c19
1 parent 2a77dd1
commit a411c19
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -34,5 +34,5 @@ jobs:
       - name: Run PHPUnit
         run: ./vendor/bin/phpunit --testdox
 
-      - name: Run PHPStan
-        run: ./vendor/bin/phpstan
+      - name: Run PHPCS
+        run: ./vendor/bin/phpcs --standard=PSR2 src/ --colors -n
diff --git a/src/Collection/StaticBufferCollection.php b/src/Collection/StaticBufferCollection.php
@@ -25,7 +25,7 @@ class StaticBufferCollection extends StaticCollection
      * StaticBufferCollection constructor.
      * @param BufferInterface ...$values
      */
-    public function __construct(BufferInterface... $values)
+    public function __construct(BufferInterface ...$values)
     {
         $this->set = $values;
     }

diff --git a/src/Key/Deterministic/HierarchicalKeySequence.php b/src/Key/Deterministic/HierarchicalKeySequence.php
@@ -64,7 +64,7 @@ public function decodeRelative(string $path): array
      * @param string ...$parts
      * @return int[]
      */
-    private function decodeDerivation(string... $parts): array
+    private function decodeDerivation(string ...$parts): array
     {
         $indices = [];
         foreach ($parts as $i => $part) {

diff --git a/src/Key/Deterministic/MultisigHD.php b/src/Key/Deterministic/MultisigHD.php
@@ -44,7 +44,7 @@ class MultisigHD
      * @param ScriptDataFactory $scriptDataFactory
      * @param HierarchicalKey ...$keys
      */
-    public function __construct(ScriptDataFactory $scriptDataFactory, HierarchicalKey... $keys)
+    public function __construct(ScriptDataFactory $scriptDataFactory, HierarchicalKey ...$keys)
     {
         if (count($keys) < 1) {
             throw new \RuntimeException('Must have at least one HierarchicalKey for Multisig HD Script');

diff --git a/src/Key/KeyToScript/Factory/KeyToScriptDataFactory.php b/src/Key/KeyToScript/Factory/KeyToScriptDataFactory.php
@@ -42,7 +42,7 @@ abstract protected function convertKeyToScriptData(PublicKeyInterface ...$keys):
      * @param KeyInterface ...$keys
      * @return ScriptAndSignData
      */
-    public function convertKey(KeyInterface... $keys): ScriptAndSignData
+    public function convertKey(KeyInterface ...$keys): ScriptAndSignData
     {
         $pubs = [];
         foreach ($keys as $key) {

diff --git a/src/Script/Factory/ScriptCreator.php b/src/Script/Factory/ScriptCreator.php
@@ -156,7 +156,7 @@ public function int(int $n)
      * @param string... $opNames
      * @return $this
      */
-    public function op(string... $opNames)
+    public function op(string ...$opNames)
     {
         $opCodes = [];
         foreach ($opNames as $opName) {

diff --git a/src/Script/Script.php b/src/Script/Script.php
@@ -255,7 +255,7 @@ public function isPushOnly(array&$ops = null): bool
      * @param WitnessProgram|null $program
      * @return bool
      */
-    public function isWitness(& $program = null): bool
+    public function isWitness(&$program = null): bool
     {
         $buffer = $this->getBuffer();
         $size = $buffer->getSize();
@@ -286,7 +286,7 @@ public function isWitness(& $program = null): bool
      * @param BufferInterface $scriptHash
      * @return bool
      */
-    public function isP2SH(& $scriptHash): bool
+    public function isP2SH(&$scriptHash): bool
     {
         if (strlen($this->script) === 23
             && $this->script[0] = Opcodes::OP_HASH160

diff --git a/src/Script/ScriptInterface.php b/src/Script/ScriptInterface.php
@@ -43,13 +43,13 @@ public function isPushOnly(array &$ops = null): bool;
      * @param WitnessProgram|null $witness
      * @return bool
      */
-    public function isWitness(& $witness): bool;
+    public function isWitness(&$witness): bool;
 
     /**
      * @param BufferInterface $scriptHash
      * @return bool
      */
-    public function isP2SH(& $scriptHash): bool;
+    public function isP2SH(&$scriptHash): bool;
 
     /**
      * @param bool $accurate