-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hex interpolator #121
Add hex interpolator #121
Conversation
(This work relates to issue #94.) Good to see you are the hack event yesterday! So to get this over the line, I think we need the following:
I'm very happy if the work ends there, but the follow on piece is the same thing but for something like: |
e0dfe4e
to
fa82f84
Compare
ultraviolet/shared/src/test/scala/ultraviolet/SyntaxTests.scala
Outdated
Show resolved
Hide resolved
ultraviolet/shared/src/test/scala/ultraviolet/SyntaxTests.scala
Outdated
Show resolved
Hide resolved
ultraviolet/shared/src/test/scala/ultraviolet/macros/ShaderMacrosTests.scala
Outdated
Show resolved
Hide resolved
ultraviolet/shared/src/test/scala/ultraviolet/acceptance/GLSLInterpolatorTests.scala
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💪
I've tried to answer your comments, give me a shout if you need help!
ultraviolet/shared/src/test/scala/ultraviolet/SyntaxTests.scala
Outdated
Show resolved
Hide resolved
ultraviolet/shared/src/test/scala/ultraviolet/SyntaxTests.scala
Outdated
Show resolved
Hide resolved
ultraviolet/shared/src/test/scala/ultraviolet/acceptance/GLSLInterpolatorTests.scala
Show resolved
Hide resolved
ultraviolet/shared/src/test/scala/ultraviolet/macros/ShaderMacrosTests.scala
Outdated
Show resolved
Hide resolved
When you get back to this @dariusj, can you please sync your fork and rebase. I've fiddled with the build a bit. Thanks! |
85f1604
to
7b0a483
Compare
ultraviolet/shared/src/main/scala/ultraviolet/macros/CreateShaderAST.scala
Outdated
Show resolved
Hide resolved
2755b56
to
2b83afa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Assuming the build passes I'm happy to get this merged. I have left a couple of comments on the error messaging, but they aren't show stoppers.
ultraviolet/shared/src/main/scala/ultraviolet/macros/CreateShaderAST.scala
Outdated
Show resolved
Hide resolved
If you're happy, you could take this out of draft? |
2b83afa
to
24e9faa
Compare
Add
hex
,hexa
,rgb
, andrgba
custom interpolators.