toggle for (concurrent) monthly ERA5 requests; progressbar disabled by default #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
2 tasks
|
See performance checks in #371 |
|
This is great. Would you mind putting a test there for checking both functionalities? Otherwise feel free to merge |
fneum
changed the title
|
I have tested this extensively and it works well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #371.
Changes proposed in this Pull Request
Adds option to toggle whether ERA5 downloads are requested in monthly or annual chunks with option to place concurrent requests with keyword argument
cutout.prepare(monthly_requests=False, concurrent_requests=False).Potential performance improvements and functionality tests shown in #371.
Checklist
doc.Unit tests for new features were added (if applicable).Newly introduced dependencies are added toenvironment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.