Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download data simultaneously and cache files #385

Closed
wants to merge 6 commits into from

Conversation

yndevops2
Copy link

@yndevops2 yndevops2 commented Oct 8, 2024

This update speeds up downloading ERA5 data by letting you download multiple files at once. It also adds caching for downloaded data and a progress bar to track the download status.

@yndevops2 yndevops2 changed the title Download data simultaneously Download data simultaneously and cache files Oct 9, 2024
@yndevops2 yndevops2 mentioned this pull request Oct 25, 2024
2 tasks
@lkstrp
Copy link
Member

lkstrp commented Oct 28, 2024

Hey @yndevops2,
all merging issues should be resolved now. Sorry for the late response, this will be better from now on. You don't need to create an extra issue for those things, just ping me here.

Please give me a bit more time to review your PR. I will test it soon. Thank you !

Copy link
Author

@yndevops2 yndevops2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still issue with codecov.
Could you please help me?

@lkstrp
Copy link
Member

lkstrp commented Oct 28, 2024

There have been some changes to the tests which might messed up your report. But that should be fine now.
To resolve the failing Code Cov you need to provide tests for your newly created functions. Check the full Codecov Report which points you to which lines need additional tests. You can implement them in /test (we use pytest).

@yndevops2
Copy link
Author

This is first time for the CodeCov.
So if you can help me for that, that would be great help for me!!!!

@yndevops2 yndevops2 closed this by deleting the head repository Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants