Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip previous encoding workaround for fixed xarray versions #401

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Skip previous encoding workaround for fixed xarray versions #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bd3014
fix: Skip previous encoding workaround for fixed xarray versions
Nov 1, 2024
332a5d1
Replace workaround by a new xarray lower bound
Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions atlite/datasets/era5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,15 +361,6 @@ def retrieve_data(product, chunks=None, tmpdir=None, lock=None, **updates):
logger.debug(f"Adding finalizer for {target}")
weakref.finalize(ds._file_obj._manager, noisy_unlink, target)

# Remove default encoding we get from CDSAPI, which can lead to NaN values after loading with subsequent
# saving due to how xarray handles netcdf compression (only float encoded as short int seem affected)
# Fixes issue by keeping "float32" encoded as "float32" instead of internally saving as "short int", see:
# https://stackoverflow.com/questions/75755441/why-does-saving-to-netcdf-without-encoding-change-some-values-to-nan
# and hopefully fixed soon (could then remove), see https://github.com/pydata/xarray/issues/7691
for v in ds.data_vars:
if ds[v].encoding["dtype"] == "int16":
ds[v].encoding.clear()

return ds


Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies = [
"pandas>=0.25",
"bottleneck",
"numexpr",
"xarray>=0.20",
"xarray>=2024.03.0",
"netcdf4",
"dask>=2021.10.0",
"toolz",
Expand Down Expand Up @@ -116,4 +116,4 @@ ignore = [
'D415', # First line should end with a period, question mark, or exclamation point
'D417', # Missing argument descriptions in the docstring

]
]