Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Voice Message Sending #2579

Merged
merged 24 commits into from
Dec 28, 2024

Conversation

Icebluewolf
Copy link
Contributor

@Icebluewolf Icebluewolf commented Sep 16, 2024

Summary

Adds support for sending voice messages. This includes the waveform and duration_sec parameters that can be used in the new VoiceMessage subclass.
Solves #2575

Resolved, was a py-cord bug: This will be a draft until I have confirmed the behavior of waveforms and duration_sec in interaction responses.
As of now I believe there is a discord bug that causes them to be ignored.

Resolved: Also Pending: DAPI #7158

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@JustaSqu1d JustaSqu1d added priority: medium Medium Priority feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib labels Sep 20, 2024
@JustaSqu1d
Copy link
Member

Potentially related commit: discord/discord-api-docs@e6cf4a9

@aaronjamt
Copy link

aaronjamt commented Oct 20, 2024

DAPI #7158 has been closed and I've been using this PR in a project for a couple weeks now without issues. Is it ready to merge?

@Icebluewolf
Copy link
Contributor Author

As far as I know this has not been officially added to the API as it is not strictly documented. Also last time I tested it I was having issues getting the waveforms to display on interaction responses.

discord/file.py Outdated Show resolved Hide resolved
discord/file.py Outdated Show resolved Hide resolved
discord/file.py Outdated Show resolved Hide resolved
discord/file.py Outdated Show resolved Hide resolved
Icebluewolf and others added 2 commits December 27, 2024 17:56
@Lulalaby Lulalaby enabled auto-merge (squash) December 28, 2024 17:18
@Lulalaby Lulalaby merged commit f8a7c3a into Pycord-Development:master Dec 28, 2024
25 checks passed
@Icebluewolf Icebluewolf deleted the voice_messages branch December 28, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature priority: medium Medium Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants