Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add optional filter parameter to utils.basic_autocomplete #2590

Merged
merged 9 commits into from
Sep 28, 2024
Merged

feat: Add optional filter parameter to utils.basic_autocomplete #2590

merged 9 commits into from
Sep 28, 2024

Conversation

sweetbrulee
Copy link
Contributor

@sweetbrulee sweetbrulee commented Sep 25, 2024 •
edited
Loading

Summary

Add optional check parameter in utils.basic_autocomplete.

If check is provided with None, a default check is used that includes items whose string representation starts with the user's input value, case-insensitive.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@sweetbrulee sweetbrulee requested a review from a team as a code owner September 25, 2024 06:25
@pullapprove4 pullapprove4 bot requested a review from WhoIsConch September 25, 2024 06:25
@Lulalaby Lulalaby requested review from plun1331 and JustaSqu1d and removed request for WhoIsConch September 25, 2024 07:13
plun1331
plun1331 reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think check is the right word for this, maybe filter?

@sweetbrulee
Copy link
Contributor Author

I totally agree with that. The only reason I chose the word check is because of the original internal function name inside basic_autocomplete.

@sweetbrulee sweetbrulee changed the title feat: Add optional check parameter in utils.basic_autocomplete feat: Add optional filter parameter in utils.basic_autocomplete Sep 25, 2024
plun1331
plun1331 reviewed Sep 26, 2024
View reviewed changes
discord/utils.py Outdated Show resolved Hide resolved
JustaSqu1d
JustaSqu1d suggested changes Sep 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sweetbrulee @JustaSqu1d
Update CHANGELOG.md
6cc03e6 
Co-authored-by: JustaSqu1d <[email protected]>
Signed-off-by: Jeffrey Ruan <[email protected]>
@sweetbrulee sweetbrulee changed the title feat: Add optional filter parameter in utils.basic_autocomplete feat: Add optional filter parameter to utils.basic_autocomplete Sep 26, 2024
plun1331
plun1331 previously approved these changes Sep 26, 2024
View reviewed changes
JustaSqu1d
JustaSqu1d suggested changes Sep 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@plun1331 @JustaSqu1d
Update CHANGELOG.md
540c527 
Co-authored-by: JustaSqu1d <[email protected]>
Signed-off-by: plun1331 <[email protected]>
plun1331
plun1331 previously approved these changes Sep 26, 2024
View reviewed changes
@plun1331 plun1331 enabled auto-merge (squash) September 26, 2024 21:54
JustaSqu1d
JustaSqu1d suggested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a usage example in the example section of the function's doc string

@sweetbrulee
Amend the filter parameter docstring
9ebbcc4 
* Clarify the description of the ``filter`` parameter
* Add usage examples for the ``filter`` parameter
auto-merge was automatically disabled September 27, 2024 19:39

Head branch was pushed to by a user without write access

@plun1331 plun1331 added the feature Implements a feature label Sep 27, 2024
@Lulalaby Lulalaby merged commit d39caa0 into Pycord-Development:master Sep 28, 2024
25 checks passed
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
@sweetbrulee @pre-commit-ci
@JustaSqu1d @plun1331 @baribarton
feat: Add optional filter parameter to utils.basic_autocomplete (Pyco…
6c66e14 
…rd-Development#2590)


Signed-off-by: Jeffrey Ruan <[email protected]>
Signed-off-by: plun1331 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: JustaSqu1d <[email protected]>
Co-authored-by: plun1331 <[email protected]>
OmLanke pushed a commit to OmLanke/pycord that referenced this pull request Dec 16, 2024
@sweetbrulee @pre-commit-ci
@JustaSqu1d @plun1331 @OmLanke
feat: Add optional filter parameter to utils.basic_autocomplete (Pyco…
f84bef4 
…rd-Development#2590)


Signed-off-by: Jeffrey Ruan <[email protected]>
Signed-off-by: plun1331 <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: JustaSqu1d <[email protected]>
Co-authored-by: plun1331 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees
No one assigned
Labels
feature Implements a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sweetbrulee @Lulalaby @plun1331 @JustaSqu1d