-
-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 Fix Interaction.channel
incorrectly set
#2658
Open
Paillat-dev
wants to merge
14
commits into
Pycord-Development:master
Choose a base branch
from
Paillat-dev:fix-interaction-channel-perms
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: 🐛 Fix Interaction.channel
incorrectly set
#2658
Paillat-dev
wants to merge
14
commits into
Pycord-Development:master
from
Paillat-dev:fix-interaction-channel-perms
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paillat-dev
force-pushed
the
fix-interaction-channel-perms
branch
from
November 28, 2024 08:42
d9af48f
to
0fcf795
Compare
Paillat-dev
force-pushed
the
fix-interaction-channel-perms
branch
from
November 28, 2024 08:57
8683daa
to
96a3141
Compare
Paillat-dev
changed the title
🐛 Fix
fix: 🐛 Fix Nov 28, 2024
Interaction.channel
incorrectly setInteraction.channel
incorrectly set
Removing |
Ok |
JustaSqu1d
suggested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix changelog entry
JustaSqu1d
suggested changes
Dec 17, 2024
Lulalaby
previously approved these changes
Dec 23, 2024
Dorukyum
reviewed
Dec 26, 2024
Dorukyum
reviewed
Dec 27, 2024
Signed-off-by: Paillat <[email protected]>
Dorukyum
previously approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InteractionPayload["channel"]
is partial, thus, when creating a GuildChannel object from it, some attributes were missing/incorrectly set. With this pr,InteractionPayload["channel"]
is used only in the following cases:In all other cases, it uses the full channel object from the cache.
Information
fixes:
permissions_for
returning wrong permissions #2281examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.