Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fixed items without images, added needed exports to items.lua #91

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Shizojin
Copy link

@Shizojin Shizojin commented Sep 12, 2024

Description

Updated ox_fuel

With default installation, items were not usable (vehiclehandler items).
Added needed exports, also changed picturenaming in items.lua for a few items / changed image names / added images because they were missing.

Still To-Do: As solareon suggested, get rid of items which aren't needed by default recipe. Just wanted to push this out asap so by default repairkit etc works without issue on unstable recipe and to prevent "repkit" not working messages etc.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ox_fuel v1.4.1+ requires server artifact version 8201+, but qbx_core minimum version is lower than this. We shouldn't update ox_fuel until we raise the minimum core version. Also why not make it latest?

@Shizojin
Copy link
Author

ox_fuel v1.4.1+ requires server artifact version 8201+, but qbx_core minimum version is lower than this. We shouldn't update ox_fuel until we raise the minimum core version. Also why not make it latest?

Didn't know about that much in detail about required and actual artifact version😅
Why not latest? Just sticked to existing template and made to actual version

Will revert back to 1.4 then because switching to latest also brings the artifact version like you mentioned.

@Shizojin Shizojin requested a review from Manason September 12, 2024 15:54
@mafewtm
Copy link
Member

mafewtm commented Sep 12, 2024

This seems unnecessary. Not to mention quite a few of these items are not used at all.

@Shizojin
Copy link
Author

This seems unnecessary. Not to mention quite a few of these items are not used at all.

Actually agree with you on that. Just wanted to make an approach where things which are included in recipe, work out of the box.
Like actual used items, and the vehiclefailure stuff like repairkit etc which need an additional export in items.lua.

But this can be easily postponed until I sorted out items which are actually used in unstable recipe and no unneded items/images are included.

@Manason Manason changed the title Fixed items without images, added needed exports to items.lua WIP: Fixed items without images, added needed exports to items.lua Sep 13, 2024
@Manason
Copy link
Member

Manason commented Sep 13, 2024

This seems unnecessary. Not to mention quite a few of these items are not used at all.

Actually agree with you on that. Just wanted to make an approach where things which are included in recipe, work out of the box. Like actual used items, and the vehiclefailure stuff like repairkit etc which need an additional export in items.lua.

But this can be easily postponed until I sorted out items which are actually used in unstable recipe and no unneded items/images are included.

I've marked the PR WIP. Feel free to mark when it's ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants