Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undefined CellReference::fromString #363

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Remove undefined CellReference::fromString #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions QXlsx/header/xlsxcellreference.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@

QT_BEGIN_NAMESPACE_XLSX

const int XLSX_ROW_MAX = 1048576;
const int XLSX_COLUMN_MAX = 16384;
const int XLSX_STRING_MAX = 32767;

class QXLSX_EXPORT CellReference
{
public:
Expand All @@ -29,7 +25,6 @@ class QXLSX_EXPORT CellReference
~CellReference();

QString toString(bool row_abs = false, bool col_abs = false) const;
static CellReference fromString(const QString &cell);
bool isValid() const;
inline void setRow(int row) { _row = row; }
inline void setColumn(int col) { _column = col; }
Expand All @@ -47,7 +42,7 @@ class QXLSX_EXPORT CellReference

inline bool operator>(const CellReference &other) const
{
return _row > other._row || _column != other._column;
return _row > other._row || _column != other._column;
}

private:
Expand Down
6 changes: 6 additions & 0 deletions QXlsx/source/xlsxworksheet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@

QT_BEGIN_NAMESPACE_XLSX

namespace {
const int XLSX_ROW_MAX = 1048576;
const int XLSX_COLUMN_MAX = 16384;
const int XLSX_STRING_MAX = 32767;
} // namespace

WorksheetPrivate::WorksheetPrivate(Worksheet *p, Worksheet::CreateFlag flag)
: AbstractSheetPrivate(p, flag)
, windowProtection(false)
Expand Down