Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PEP604 type annotations #197

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Use PEP604 type annotations #197

merged 4 commits into from
Dec 16, 2024

Conversation

neNasko1
Copy link
Contributor

As discussed with @cbourjau, this PR introduces the PEP604 way of writing Union-s and Optional-s into the repo.

This does not need a CHANGELOG.rst entry as it is not user-facing.

adityagoel4512
adityagoel4512 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@adityagoel4512 adityagoel4512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbourjau cbourjau merged commit cc2c2f9 into main Dec 16, 2024
18 checks passed
@cbourjau cbourjau deleted the use-pipe-type-annotations branch December 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagoel4512 adityagoel4512 adityagoel4512 approved these changes

@cbourjau cbourjau Awaiting requested review from cbourjau cbourjau is a code owner

@jbachurski jbachurski Awaiting requested review from jbachurski jbachurski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neNasko1 @adityagoel4512 @cbourjau