Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Added ase Nudged Elastic Band in the NewtonNet recipe #2176
base: main
Are you sure you want to change the base?
WIP: Added ase Nudged Elastic Band in the NewtonNet recipe #2176
Changes from 156 commits
027e759
0840c8c
c1427d8
1646d42
bfc9ced
716e628
a9d5ff2
30d11dc
33b8d4e
f615130
40c29ca
87a08ce
dc10ecc
4fea200
6c6583b
f18ea76
f06ac43
28ced33
b13b4aa
953ec3a
b3c9c1a
04e92dc
411ac3c
2acf47f
695febf
f44380d
dc124cc
d6f8b5f
62ab50a
fe98bce
92b10d3
9e76d64
1cadf16
f9c854b
ad207b8
109c1d8
4143de1
c79b2a1
2774be2
c85d539
70b43d3
bf0a280
c24cb76
adc8396
a1c3c9f
09c9a4d
dcd284a
01105ab
0a0cff4
5400196
9575103
9697a29
8c6b015
160fa21
ca46eae
42d0da2
a7cdef2
91d556a
c025d0d
03e23a2
045facb
191e3a8
9ff5d75
b8d3f6a
d19ce44
fe3f2cf
4254141
ea6392f
90943e0
fa830b1
363bd0c
ec3bfd8
20c3443
9bb1c39
2f5b531
f2ef51b
f8b7438
f88a6ba
4253d94
df6c245
a0245c5
273ba6b
741c780
54312a7
994dd46
93e1356
6533f83
d709cec
4c1b3a8
72b0134
1838b1c
13cdff4
59fc5e3
b1ea1d2
b831ab8
35a13ae
502253b
44d365a
7a8924b
b870a7d
59ace9c
160b232
acce40e
c0c9655
8ae1bde
18fd593
49da3eb
3120fae
dae5796
d2d8ffd
9a6c9ca
5ce7cd8
c38b6c8
11cd0b9
905c906
cba79d3
01bfb17
979d193
0ff073c
d3eab91
dc7c80b
bb58d2e
99bc8d5
39494c0
3468dcb
6ba14ef
45c4070
a12fad8
dd1c6cb
51aac67
5990dfc
9c47266
da6c3af
32ad251
6eb3582
bf752c4
b2b0466
d028529
43d1504
b9c8bd0
2c46a94
b7cf522
299c440
439de1e
1bd71bf
36d933e
314851d
fa02d79
7db0b1f
d737a93
0a40aa8
81b05ce
7187de3
04bafa4
2a7645a
6bea8a7
9356e8b
e5c3aee
c1704a5
d5b481e
5689e2b
a673acd
afa79da
c2605a5
c2d43f6
9377a82
f9e4af6
326f925
6fa67ee
b88c40c
4b33856
58766ee
ec95533
7adf08e
50eaf8b
e446487
e263622
60b7aef
93cf42d
003e056
ee28b48
a069d89
4c2d20f
24b04cd
5483d27
79ec33d
7da2d1d
0130aa3
2ff1bef
0d79cbf
7b9a9e4
3c78709
8cab2cc
a41fb04
0665ee6
ad975ab
e36c3ea
5a8b6f0
93a93b6
f6e789b
f75f70a
00b0e63
7994881
bf05f39
eac9687
d363d5e
b47725a
25e79a0
d545f8b
30a7dc6
6023819
1a4b1a1
dc4cd86
4e8a05c
db157db
19685f1
c2ef8cb
f140801
18a58dc
05862d9
5465aa1
2c867db
7c9e819
4d9dcc8
5d92bfa
c72b95a
fe00971
9a43dff
c5ddcfa
7128288
777160d
68d7ec9
2ba31ad
fce697e
e35f912
49a21db
fa3150f
d65aef9
7bbff3b
7c680a9
0f99a89
6e374de
c67c622
b722a35
b453027
bf9d699
aa5d323
6e8058f
6b01611
833383f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of the same code between your three newly added functions. You should consider refactoring them such that you do not introduce large blocks of duplicated code into the codebase.