-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New interface for belief propagation decoder #12
Conversation
- Added Structs for BPSetup, BPDecoder, BPDecoderSparse - Added Methods for decode! and batchdecode! - Added Tests for above methods - Updated README.md, gitignore, project.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! It is a great start!
Thank you Stefan! I will ping you after the doing the updates. |
@Krastanov I have pushed the suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a doctest runner? Here is an example:
https://github.com/QuantumSavory/BPGates.jl/blob/main/test/test_doctests.jl
And could you click "resolve" on comments of mine above that you have already dealt with. It helps me when I get back to this PR after looking at something else. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Check out the last commit I added here. It brings over a bunch more CI tooling. I added the static analysis tools JET.jl and Aqua.jl Could you look into the spelling CI and the jet=true CI ? In particular, JET is reporting the following:
|
If you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer
Before considering your pull request ready for review and merging make sure that all of the below are completed: