Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New interface for belief propagation decoder #12

Merged
merged 6 commits into from
Mar 6, 2024
Merged

New interface for belief propagation decoder #12

merged 6 commits into from
Mar 6, 2024

Conversation

krishna-praneet
Copy link
Contributor

  • Added Structs for BPSetup, BPDecoder, BPDecoderSparse
  • Added Methods for decode! and batchdecode!
  • Added Tests for above methods
  • Updated README.md, gitignore, project.toml

If you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer

Before considering your pull request ready for review and merging make sure that all of the below are completed:

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All changes and new functionality are marked in the CHANGELOG file.

- Added Structs for BPSetup, BPDecoder, BPDecoderSparse
- Added Methods for decode! and batchdecode!
- Added Tests for above methods
- Updated README.md, gitignore, project.toml
@krishna-praneet krishna-praneet marked this pull request as draft March 1, 2024 07:31
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! It is a great start!

src/LDPCDecoders.jl Outdated Show resolved Hide resolved
src/decoders/belief_propogation.jl Outdated Show resolved Hide resolved
src/decoders/belief_propogation.jl Outdated Show resolved Hide resolved
test/test_bp_decoder.jl Outdated Show resolved Hide resolved
test/test_bp_decoder.jl Outdated Show resolved Hide resolved
@krishna-praneet
Copy link
Contributor Author

Thank you Stefan! I will ping you after the doing the updates.

@krishna-praneet krishna-praneet marked this pull request as ready for review March 5, 2024 02:16
@krishna-praneet
Copy link
Contributor Author

@Krastanov I have pushed the suggested changes

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a doctest runner? Here is an example:

https://github.com/QuantumSavory/BPGates.jl/blob/main/test/test_doctests.jl

src/LDPCDecoders.jl Outdated Show resolved Hide resolved
src/decoders/belief_propogation.jl Outdated Show resolved Hide resolved
src/decoders/belief_propogation.jl Show resolved Hide resolved
src/syndrome_decoder.jl Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/syndrome_decoder.jl Outdated Show resolved Hide resolved
@Krastanov
Copy link
Member

And could you click "resolve" on comments of mine above that you have already dealt with. It helps me when I get back to this PR after looking at something else.

Copy link

codecov bot commented Mar 6, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@Krastanov
Copy link
Member

Check out the last commit I added here. It brings over a bunch more CI tooling. I added the static analysis tools JET.jl and Aqua.jl

Could you look into the spelling CI and the jet=true CI ?

In particular, JET is reporting the following:

┌ row_echelon(matrix::Any) @ LDPCDecoders /home/runner/work/LDPCDecoders.jl/LDPCDecoders.jl/src/util.jl:10
│┌ row_echelon(matrix::Any, full::Bool) @ LDPCDecoders /home/runner/work/LDPCDecoders.jl/LDPCDecoders.jl/src/util.jl:22
││ `LDPCDecoders.transform_matrix` is not defined: LDPCDecoders.transform_matrix
│└────────────────────
│┌ row_echelon(matrix::Any, full::Bool) @ LDPCDecoders /home/runner/work/LDPCDecoders.jl/LDPCDecoders.jl/src/util.jl:28
││ `LDPCDecoders.not` is not defined: goto %115 if not LDPCDecoders.not
│└────────────────────
│┌ row_echelon(matrix::Any, full::Bool) @ LDPCDecoders /home/runner/work/LDPCDecoders.jl/LDPCDecoders.jl/src/util.jl:55
││ `LDPCDecoders.transform_matrix` is not defined: Base.vect(row_esch_matrix, matrix_rank, LDPCDecoders.transform_matrix, LDPCDecoders.pivot_cols)
│└────────────────────

@Krastanov Krastanov merged commit 7f44f7e into main Mar 6, 2024
9 of 14 checks passed
@Krastanov Krastanov deleted the bp-decoder branch March 6, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants