Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added improved decoder code in decode function itself #15

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

krishna-praneet
Copy link
Contributor

If you want to submit an unfinished piece of work in order to get comments and discuss, please mark the pull request as a draft and ping the repository maintainer

Before considering your pull request ready for review and merging make sure that all of the below are completed:

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All changes and new functionality are marked in the CHANGELOG file.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 42.30%. Comparing base (3482b4c) to head (03eef01).

Files Patch % Lines
src/decoders/belief_propagation.jl 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   36.27%   42.30%   +6.03%     
==========================================
  Files          13       13              
  Lines         419      468      +49     
==========================================
+ Hits          152      198      +46     
- Misses        267      270       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quick questions.

src/decoders/belief_propagation.jl Outdated Show resolved Hide resolved
src/decoders/belief_propagation.jl Outdated Show resolved Hide resolved
src/decoders/belief_propagation.jl Outdated Show resolved Hide resolved
@Krastanov Krastanov merged commit 6c6cb2d into main Apr 3, 2024
10 of 14 checks passed
@Krastanov
Copy link
Member

Thank you!

@Krastanov Krastanov deleted the improved-decoder branch April 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants