Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace spawn with coroutine in MasterClock.lua #176

Open
wants to merge 1 commit into
base: version2
Choose a base branch
from
Open

replace spawn with coroutine in MasterClock.lua #176

wants to merge 1 commit into from

Conversation

jakebball
Copy link

replaces spawn with coroutine.wrap for immediate start and future proofing.

@jakebball
replace spawn with coroutine in MasterClock.lua
3e66eff 
replaces spawn with coroutine.wrap for immediate start future proofing
T-R-I-X
T-R-I-X approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@T-R-I-X T-R-I-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better optimization than spawn().

@Quenty
Copy link
Owner

Quenty commented Dec 3, 2020

if we're using wait(5) then there's really no point here in using coroutine.wrap().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-R-I-X T-R-I-X T-R-I-X approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebball @Quenty @T-R-I-X