-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for partial chunk/region load #49
Conversation
public static long TILE_ENTITIES = 0x0010; | ||
public static long CARVING_MARKS = 0x0020; | ||
public static long TILE_TICKS = 0x0040; | ||
public static long LIQUID_TILE_TICKS = 0x0040; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LIQUID_TILE_TICKS should not be the same as TILE_TICKS
public static long BLOCK_STATES = 0x0800; | ||
public static long SKY_LIGHT = 0x1000; | ||
public static long LIGHTS = 0x2000; | ||
public static long LIQUIDS_TO_BE_TICKED = 0x2000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LIQUIDS_TO_BE_TICKED should not be the same as LIGHTS
Right now when trying to save a chunk that only has been partially loaded it will throw an NPE (see Chunk.java#L600 which is called in Chunk.java#L133). I think it would be better to throw an |
Thanks! I also realized that I have a lot of OR when it should be AND. I have NO idea what I was thinking. :) |
…unk on save. Upgraded gradle
Made a lot of changes: Fixed all my bugs described above. |
|
|
Thanks! Is this ready to be merged now, or are there more changes you'd like? |
lgtm |
Implemented partial load of chunks and regions as described in #48.