Enable QUICK conversion on add/remove liquidity #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable QuickConverter to receive requests from approved contracts (not just tx.origin) Add converter.convert() to the end of addLiquidity, addLiquidityETH, and removeLiquidity
|
Hhh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable QuickConverter to receive requests from approved contracts (not just tx.origin)
Add converter.convert() to the end of addLiquidity, addLiquidityETH, and removeLiquidity
This hasn't been tested. Other than adding the conversion step, the router code should be identical, so it's low risk. I have not audited this for potential reentrancy attacks, but I think it's safe because the added code can only function if there's a uni-v2 balance, and the uni-v2 balance can only be added by other contracts.
It's possible this can enable a flash loan attack, though I don't think that can happen because you can't add anything between the mint/burn and the convert steps are atomic, and nothing can be inserted between them