feat(loader): cli parameter to ignore unknown mods #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexIIL
requested changes
May 29, 2024
There was a problem hiding this comment.
Thanks for the PR! I agree that this is needed, but not quite with how this is implemented.
Specifically:
- Quilt-loader generally uses system properties to configure its behavior - these are the static constants in
SystemProperties. Can you replace the argument with a system property likeloader.ignore_unsupported_mods? (This also means we don't pass it to minecraft, which logs a message likeCompletely ignored arguments: [--ignore-unknown-mods]) - I think this is the wrong place to filter out ignored mods - the window which gets hidden could contain unrelated warnings (in the
Filestab) which should still be shown if the config optionalways_show_mod_state_windowis enabled. Instead, this should probably go inQuiltPluginManagerImpl.populateModsGuiTab(where the warnings are generated) - basically just skip the unsupported mod checking if the system property is set to true.
|
@AlexIIL, thanks for the review, will redo :) |
|
@AlexIIL, reimplemented, tested — that also works |
AlexIIL
approved these changes
May 29, 2024
|
Thanks! |
steviegt6
referenced
this pull request
in steviegt6/fable
Jul 2, 2024
* Add missing changelog entry. * Bump for 0.25.0 release. * Publish dependencies as seperate module (#418) * Dependency publishing and use toolchains * Fix up tests and exclude specific included dependencies * Add foojay for toolchains to work * Add a system property to disable DelegatingUrlStreamHandlerFactory. (#424) * Fix "2.x" not appending an empty build version to the resulting predicate. (#425) This used to turn "2.x" or "=2.x" into "^2-", however a while ago this accidently got changed to "^2". Honestly, I'm unsure which way is correct. However this was changed accidently during our Version.Sementic switching to non-null build & pre-release, so it's been changed back. * Add missing license * Change indentation in McVersionLookup to match upstream * 24w14potato support forked from 24w12a * 24w14potato support (part 2) * Update Mixin (#919) * Update Mixin * Update Mixin * 0.26.0 changelog, and bump for beta release 0.26.0-beta.1 * bump qconf (#423) * Update changelog * Link * Fix Fabric mod author and contributor being duplicated (#427) * Fix mod contributors being reordered when read (#426) * Fix regression which moved the global cache to the wrong location (#429) * Bump version * Allowed the GameProvider to provide the namespace (#428) * Allowed the GameProvider to provide the namespace * Removed the deprivation warning on the MappingConfiguration * Removed process functions where the namespace isn't provided from being deprecated in the GamePatch * Fixup of commit f71eda1a with AlexIIL's suggestions * Allowed for no namespace to be provided when locating entrypoints * Release beta * Fix knot class loading allowlist not working (#430) * Bump version * Add a system property to disable unsupported mod warnings (#434) The system property is `loader.ignore_unsupported_mods` - set this to true with `-Dloader.ignore_unsupported_mods=true` to ignore all unsupported mods. This is a straightforward solution to #433. * Two changes to dates in the report generator: - Include the zone offset (raw time number like +0100) in the actual crash report file. This should help when assisting people in other timezones - as we can figure out if a crash report was generated just now, or is an older one. - Change from CLOCK_HOUR_OF_DAY to HOUR_OF_DAY. This means we'll get digital time at 15 minutes past midnight (00:15) rather than analog time (24:15) * Added support for 1.21 * Provide fabric loader 0.15.11 * Bump for beta. (Just before releasing a proper stable -_- ) * Update changelog * Bump for 0.26.0 release! * Fixed crash reports being printed to system out, rather than the log. (This is a problem for launchers which don't replay sysout, like Modrinth) * Fixed the gui system closing the whole game if the forked gui process encountered an error, rather than returning the error to the original process. * Two bug fixes: 1: Implement additional reflections patch system for shaded versions of the reflections library. Currently this only targets the one used by kubejs-offline. (TODO) Add system property support for additional packages. 2: Fix gui icons being sent too early, causing crashes in the gui server. Also added a new system property to print all gui packets. * Add missing license headers. * Change plugin classes to be made available after plugins have been loaded. * Delete. * Update licenses. --------- Co-authored-by: AlexIIL <[email protected]> Co-authored-by: Luke Bemish <[email protected]> Co-authored-by: modmuss50 <[email protected]> Co-authored-by: ix0rai <[email protected]> Co-authored-by: Lilly Rose Berner <[email protected]> Co-authored-by: glitch <[email protected]> Co-authored-by: coolGi <[email protected]> Co-authored-by: Vasiliy <[email protected]> Co-authored-by: WinPlay02 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #433 restoring old behavior (not shore which version this GUI was introduced in) with extra cli argument
--ignore-unknown-mods