-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Data Centers button from Main Menu #909
Conversation
Imma bypass the labels because it's literally one-line change, just gonna wait for people to approve so it can get merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, game doesn't magically explode when opening the main menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't handle -vanilla
Granted, a lot of things currently dont handle it, but I'd rather not add more to the pile
@ASpoonPlaysGames Add the const to the compile check smh |
Is it not there already? I won't be at my pc today, @GeckoEidechse any chance you could add it? |
Sadly won't get the chance today :/ |
Oh wait this might need an update to the GH action |
@ASpoonPlaysGames bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
We actually don't use them at all, there's no reason for the button to stay there, plenty of people do actually think they connect into Northstar servers through them only because the button is still there, when in fact it has zero impact on anything.