Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Data Centers button from Main Menu #909

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

Zanieon
Copy link
Contributor

@Zanieon Zanieon commented Nov 30, 2024

We actually don't use them at all, there's no reason for the button to stay there, plenty of people do actually think they connect into Northstar servers through them only because the button is still there, when in fact it has zero impact on anything.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 30, 2024
@Zanieon
Copy link
Contributor Author

Zanieon commented Nov 30, 2024

Imma bypass the labels because it's literally one-line change, just gonna wait for people to approve so it can get merged.

@Zanieon Zanieon added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Nov 30, 2024
@Zanieon Zanieon self-assigned this Nov 30, 2024
Copy link
Contributor

@NachosChipeados NachosChipeados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, game doesn't magically explode when opening the main menu

@GeckoEidechse GeckoEidechse added the feedback wanted Feedback is wanted whether the changes by this PR are desired label Nov 30, 2024
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't handle -vanilla

Granted, a lot of things currently dont handle it, but I'd rather not add more to the pile

@Zanieon
Copy link
Contributor Author

Zanieon commented Nov 30, 2024

@ASpoonPlaysGames Add the const to the compile check smh

@ASpoonPlaysGames
Copy link
Contributor

@ASpoonPlaysGames Add the const to the compile check smh

Is it not there already? I won't be at my pc today, @GeckoEidechse any chance you could add it?

@GeckoEidechse
Copy link
Member

Sadly won't get the chance today :/
Also, how do I even do that? ^^"

@ASpoonPlaysGames
Copy link
Contributor

Oh wait this might need an update to the GH action

@GeckoEidechse
Copy link
Member

@ASpoonPlaysGames bump

Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed feedback wanted Feedback is wanted whether the changes by this PR are desired almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Dec 7, 2024
@GeckoEidechse GeckoEidechse changed the title Remove Data Centers from Main Menu Remove Data Centers button from Main Menu Jan 1, 2025
@GeckoEidechse GeckoEidechse merged commit 5b67e5e into R2Northstar:main Jan 1, 2025
3 checks passed
@Zanieon Zanieon deleted the datacenter_hide branch January 1, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
READY TO MERGE This mergeable right now
Projects
Status: No status
Status: Zanieon Doing
Development

Successfully merging this pull request may close these issues.

4 participants