-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mxr to onnx #3682
base: develop
Are you sure you want to change the base?
mxr to onnx #3682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3682 +/- ##
===========================================
- Coverage 92.21% 91.68% -0.53%
===========================================
Files 514 516 +2
Lines 21750 22092 +342
===========================================
+ Hits 20056 20256 +200
- Misses 1694 1836 +142 ☔ View full report in Codecov by Sentry. |
tools/check_stamped.py
Outdated
args = parser.parse_args() | ||
|
||
main(args.branch) | ||
main(args.against) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these changes in this PR, they should go into another PR.
py_dict[py::str(v.get_key())] = to_py_object(v.without_key()); | ||
} | ||
result = py_dict; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this into the visitor below.
else | ||
{ | ||
val.visit_value([&](const auto& x) { | ||
if constexpr(std::is_same_v<std::decay_t<decltype(x)>, std::vector<migraphx::value>>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use std::is_same<..>{}
instead.
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Changes to migraphx_py to expose information about instruction_ref to engineer ONNX file.