Enable cpp core guidlines checks.

CMakeLists.txt

@@ -221,7 +221,6 @@ rocm_enable_clang_tidy(
         -cppcoreguidelines-pro-type-reinterpret-cast
         -cppcoreguidelines-pro-type-union-access
         -cppcoreguidelines-pro-type-vararg
-        -cppcoreguidelines-rvalue-reference-param-not-moved
         -cppcoreguidelines-special-member-functions
         -cppcoreguidelines-use-default-member-init
         -cppcoreguidelines-virtual-class-destructor

src/program.cpp

@@ -894,15 +894,16 @@ void program::mark(const parameter_map& params, marker&& m)
     eval(params);
     this->finish();
     // Start marking
-    m.mark_start(*this);
+    auto moved_marker = std::move(m);
+    moved_marker.mark_start(*this);
     generic_eval(*this, ctx, params, [&](auto ins, auto f) {
         argument result;
-        m.mark_start(ins);
+        moved_marker.mark_start(ins);
         result = f();
-        m.mark_stop(ins);
+        moved_marker.mark_stop(ins);
         return result;
     });
-    m.mark_stop(*this);
+    moved_marker.mark_stop(*this);
 }
 
 void program::perf_report(

test/ref/add.cpp

@@ -171,9 +171,10 @@ TEST_CASE(fp32_fp16_test)
     };
 
     auto test_case = [&](std::vector<std::string>&& op_names) {
+        auto local_op_names = std::move(op_names);
         std::vector<float> gold_res = {2.0, 4.0, 6.0, 8.0, 10.0, 12.0};
         auto p                      = create_program();
-        migraphx::quantize_fp16(p, op_names);
+        migraphx::quantize_fp16(p, local_op_names);
         p.compile(migraphx::make_target("ref"));
         auto result = p.eval({}).back();
         std::vector<float> res;