Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl adaptive avgpool #3301

Open
wants to merge 49 commits into
base: develop
Choose a base branch
from
Open

Impl adaptive avgpool #3301

wants to merge 49 commits into from

Conversation

hieule88
Copy link
Collaborator

@hieule88 hieule88 commented Oct 7, 2024

  • Added AdaptiveAvgPool 1D 2D 3D forward and backward.

  • Added driver test and gtest for AdaptiveAvgPool .

  • New API is guarded by MIOPEN_BETA_API macro.

  • Full benchmark here: link

  • Average over all cases:

  • AdaptiveAvgPool 1D

Type Forward Backward
float16 2.26 1.94
float32 2.01 1.97
bfloat16 2.25 1.97
  • AdaptiveAvgPool 2D
Type Forward Backward
float16 4.48 1.38
float32 3.15 1.31
bfloat16 3.65 1.39
  • AdaptiveAvgPool 3D
Type Forward Backward
float16 2.14 1.72
float32 2.03 2.06
bfloat16 2.13 1.71

@hieule88 hieule88 marked this pull request as ready for review October 15, 2024 08:21
@hieule88 hieule88 requested review from a team, JehandadKhan and junliume as code owners October 15, 2024 08:21
@hieule88 hieule88 self-assigned this Oct 18, 2024
@hieule88 hieule88 force-pushed the impl_adaptive_avgpool branch from ae71d69 to bd72a3e Compare October 18, 2024 07:03
@iq136boy
Copy link
Contributor

CI passed. But the PR still need to solve conflict before it is getting merged.

Copy link
Contributor

@iq136boy iq136boy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error_log:
3301_log.txt

@hieule88
Copy link
Collaborator Author

Error_log: 3301_log.txt

I fixed this error. Please send me the newest error log of this PR.

Copy link
Contributor

@iq136boy iq136boy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error log:
3301_log (2).txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants