This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Fix AMD CoMGR loading #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally should also be forward/backported to other relevant ROCM versions.
HIPRtc currently does not correctly support LLVM plugins. Specifically, symbols defined within LLVM and/or clang are not available by any plugins when they are loaded. This is partially due to the fact that the one location with these symbols (libamd_comgr) does not mark these symbols as being available globally when it is loaded.
This patch is the first of two pieces required to support LLVM plugins on ROCm, the second of which is a change to ensure libamd_comgr marks LLVM/Clang symbols as exported for when it loads the plugin (ROCm/ROCm-CompilerSupport#43).
cc @jedbrown @LeilaGhaffari